Repository navigation
feat(settings): one page per settings section - #56
Merged
Merged
Conversation
Settings is a list of pages beside the open one; under 700 px the list and one page take turns, with a Back button. Opening a page moves focus to its heading, the last page is remembered, a page that needs fixing is marked in the list, and every link into Settings opens its own page.
# Conflicts: # CHANGELOG.md # src/u1control/ui/app.html # ui/build.json
…flip the Back arrow
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings is no longer one long form. Each section is its own page:
Pages: Mode, Print setup, Options, Calibration, Connection, Extended firmware, Requirements, Language, About.
Every link into Settings opens the page it is about:
show_tab) opens Print setup once the config has arrived, since that page appears only then.The page component (
ui/src/components/SettingsPages.vue) is the same file in all six plugins and is built on ui-foundation 4.2.2'sOuiSettings.ui/sharedis unchanged. New labels:settings.back,settings.hasErrorin all six languages.This also fixes
ui/tests/page/shots.mjs, which still clicked aspoolmansettings section that no longer exists.Tests
show_tabbefore and after the config, and Open Settings with no printer.openSettings('<page>')names a real page.python -m unittest discover -s tests: 460 OK.