Skip to content

feat(settings): one page per settings section - #56

Merged
bloodf merged 5 commits into
mainfrom
feat/settings-pages
Nov 19, 2026
Merged

bloodf merged 5 commits into
mainfrom
feat/settings-pages

Conversation

@bloodf

@bloodf bloodf commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Settings is no longer one long form. Each section is its own page:

  • Wide: the list of pages on the left, the open page on the right.
  • Narrow (under 700 px): the list first, then one page at a time with a Back button.
  • Opening a page moves focus to its heading. The list is a tablist (arrow keys, Home, End).
  • The last open page is remembered (localStorage, wrapped in try/catch).
  • Print setup is marked in the list while it is off, and an invalid field marks its page as an error. Saving works exactly as before (Save, Discard).

Pages: Mode, Print setup, Options, Calibration, Connection, Extended firmware, Requirements, Language, About.

Every link into Settings opens the page it is about:

  • "Open Settings" with no printer, on the Dashboard or in the banner, opens Connection.
  • The print setup's "Plugin settings" (show_tab) opens Print setup once the config has arrived, since that page appears only then.

The page component (ui/src/components/SettingsPages.vue) is the same file in all six plugins and is built on ui-foundation 4.2.2's OuiSettings. ui/shared is unchanged. New labels: settings.back, settings.hasError in all six languages.

This also fixes ui/tests/page/shots.mjs, which still clicked a spoolman settings section that no longer exists.

Tests

  • Page tests (headless Chrome, fake bridge): wide and narrow layouts, focus on the heading, Back, arrow keys, the remembered page, show_tab before and after the config, and Open Settings with no printer.
  • Unit test: every page has a section and a label in every language, and every openSettings('<page>') names a real page.
  • python -m unittest discover -s tests: 460 OK.

Settings is a list of pages beside the open one; under 700 px the list
and one page take turns, with a Back button. Opening a page moves focus
to its heading, the last page is remembered, a page that needs fixing is
marked in the list, and every link into Settings opens its own page.
# Conflicts:
#	CHANGELOG.md
#	src/u1control/ui/app.html
#	ui/build.json
@bloodf
bloodf merged commit 9563d54 into main Nov 19, 2026
4 checks passed
@bloodf
bloodf deleted the feat/settings-pages branch November 19, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant