Repository navigation
fix(ui): loaded toolhead of unknown amount drawn full with a ? badge - #54
Merged
Merged
Conversation
Vendor ui-foundation 4.2.2. OuiSlot no longer substitutes a 60 % level for an unknown amount, so the workaround that passed 0 of 1 (which drew a loaded slot of unknown amount exactly like an empty one) is gone: the real fraction, or null when unknown, is passed through. A loaded spool with a colour and no amount now draws as a full reel in its colour with a small "?" badge; an empty slot keeps the bare reel. The text is unchanged.
…spool # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors ui-foundation 4.2.2 and drops the workaround from the last spool PR.
4.2.2 changes how an unknown amount is drawn:
data-unknown)OuiSlot no longer swaps in a 60 % level for an unknown amount, so passing 0 of 1 to avoid that level is no longer needed. That workaround made a loaded slot of unknown amount look exactly like an empty one. The real fraction is passed through now, or null when it is unknown. The text next to the spool is unchanged.
Tests: the printer-photo page test now also checks the toolhead cards: T1 and T4 at their Spoolman level, T2 (loaded, no spool) level 1 with the badge, T3 (empty) the bare reel. headFraction still returns null for unknown. The Python suite (460) passes locally. main (0.13.0) is merged in.