Skip to content

fix(ui): loaded toolhead of unknown amount drawn full with a ? badge - #54

Merged
bloodf merged 2 commits into
mainfrom
ui/oui-4.2.2-unknown-spool
Nov 18, 2026
Merged

bloodf merged 2 commits into
mainfrom
ui/oui-4.2.2-unknown-spool

Conversation

@bloodf

@bloodf bloodf commented Nov 18, 2026

Copy link
Copy Markdown
Owner

Vendors ui-foundation 4.2.2 and drops the workaround from the last spool PR.

4.2.2 changes how an unknown amount is drawn:

  • known amount: as before
  • filament loaded, amount unknown: full reel in the filament colour with a small "?" badge (data-unknown)
  • nothing loaded: the bare reel, as before

OuiSlot no longer swaps in a 60 % level for an unknown amount, so passing 0 of 1 to avoid that level is no longer needed. That workaround made a loaded slot of unknown amount look exactly like an empty one. The real fraction is passed through now, or null when it is unknown. The text next to the spool is unchanged.

Tests: the printer-photo page test now also checks the toolhead cards: T1 and T4 at their Spoolman level, T2 (loaded, no spool) level 1 with the badge, T3 (empty) the bare reel. headFraction still returns null for unknown. The Python suite (460) passes locally. main (0.13.0) is merged in.

Vendor ui-foundation 4.2.2. OuiSlot no longer substitutes a 60 % level for
an unknown amount, so the workaround that passed 0 of 1 (which drew a
loaded slot of unknown amount exactly like an empty one) is gone: the real
fraction, or null when unknown, is passed through. A loaded spool with a
colour and no amount now draws as a full reel in its colour with a small
"?" badge; an empty slot keeps the bare reel. The text is unchanged.
@bloodf
bloodf merged commit 487ab6e into main Nov 18, 2026
7 of 8 checks passed
@bloodf
bloodf deleted the ui/oui-4.2.2-unknown-spool branch November 18, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant