Skip to content

fix: print setup window blank on Windows when the plate preview makes the page too big - #53

Merged
bloodf merged 6 commits into
bloodf:mainfrom
xtronets:fix/setup-window-page-size
Nov 19, 2026
Merged

bloodf merged 6 commits into
bloodf:mainfrom
xtronets:fix/setup-window-page-size

Conversation

@xtronets

Copy link
Copy Markdown
Contributor

Since 0.12.1, on Windows (OrcaSlicer 2.5.1) the U1 Control — print setup window opens blank and the job ends with "the print setup window didn't open (OrcaSlicer was busy); nothing was sent".

Cause: the path preview (MAX_SEGMENTS = 30000, ~0.6 MB of JSON) made the page ~1.78 MB (1.2 MB app + 540 KB preview for a 48 min plate). OrcaSlicer's WebView2 doesn't render it, so the page never posts ready. The same page renders fine in Chromium, and the window works again once the preview is removed (1.24 MB). The tab, which has no preview, works.

Fix:

  • preview.py: MAX_SEGMENTS 30000 → 8000 (~150 KB).
  • ask_setup: if the page still exceeds SETUP_PAGE_LIMIT (1.45 MB), it is shown without the path preview (the thumbnail stays), and this is logged.
  • Test: test_preview_left_out_when_the_page_would_be_too_big.

I don't know WebView2's exact threshold. 1.45 MB sits between the size that failed and the one that worked. Also note that the app page alone is already ~1.2 MB.

Tests: all pass except test_spooler_joint and test_ui_page (no Spooler checkout / Node 24 here), which fail the same way on main.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DZoELyZYfky9kVSMua9P1M

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants