Repository navigation
fix: print setup window blank on Windows when the plate preview makes the page too big - #53
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 0.12.1, on Windows (OrcaSlicer 2.5.1) the U1 Control — print setup window opens blank and the job ends with "the print setup window didn't open (OrcaSlicer was busy); nothing was sent".
Cause: the path preview (
MAX_SEGMENTS = 30000, ~0.6 MB of JSON) made the page ~1.78 MB (1.2 MB app + 540 KB preview for a 48 min plate). OrcaSlicer's WebView2 doesn't render it, so the page never postsready. The same page renders fine in Chromium, and the window works again once the preview is removed (1.24 MB). The tab, which has no preview, works.Fix:
preview.py:MAX_SEGMENTS30000 → 8000 (~150 KB).ask_setup: if the page still exceedsSETUP_PAGE_LIMIT(1.45 MB), it is shown without the path preview (the thumbnail stays), and this is logged.test_preview_left_out_when_the_page_would_be_too_big.I don't know WebView2's exact threshold. 1.45 MB sits between the size that failed and the one that worked. Also note that the app page alone is already ~1.2 MB.
Tests: all pass except
test_spooler_jointandtest_ui_page(no Spooler checkout / Node 24 here), which fail the same way onmain.🤖 Generated with Claude Code
https://claude.ai/code/session_01DZoELyZYfky9kVSMua9P1M