Skip to content

fix(presets): list other printers' presets after a link; explain spool-only links - #64

Merged
bloodf merged 1 commit into
mainfrom
fix/preset-link-polish
Nov 17, 2026
Merged

bloodf merged 1 commit into
mainfrom
fix/preset-link-polish

Conversation

@bloodf

@bloodf bloodf commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Low items from the #63 re-check.

  • Preset list: the spool detail also lists Spooler's presets for the printers a linked preset doesn't fit. They come after the linked one, so Send still reaches them.
  • Spool-only links: when the picked preset is linked to that spool alone, Send is off. The help text says why: Spoolman keeps settings on the shared filament. The plugin already refused this case; the page now says so before you click. The text is in all six languages.
  • Docs: the guide and both READMEs' FAQ explain what link_fits can't judge for a printer that isn't selected:
    • a preset limited only by a compatibility condition;
    • a preset whose compatible printers list only your own copy of a printer preset.
      In both cases the spool keeps Spooler's preset on the other printers.

Test plan

  • ruff, Python 724 tests OK, UI unit 58/58, page 84/84 (S03 now covers a filament link that sends and a spool-only link that's off, with the reason).
  • CI

…l-only links

- spool_presets: Spooler's presets for printers the link doesn't fit
  follow the linked one.
- Spool detail: Send is off for a link set on the spool alone, with
  the reason in place of the help text.
- Docs: what link_fits can't judge for a printer that isn't selected
  (condition-only presets, printer copies listed by name).
@bloodf
bloodf merged commit a257db6 into main Nov 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant