Repository navigation
feat: link a spool to your own OrcaSlicer preset; Send to Spoolman acts on the picked preset - #62
Merged
Merged
Conversation
…oolman acts on the picked preset orca_filament_preset, a Spoolman text extra field on the spool (else its filament), names one of your own filament presets. Edit Spool offers the choice and adds the field. A linked spool gets no Spooler preset, and the linked one is picked wherever Spooler would pick its own. Send to Spoolman compared the edited preset with find_preset(), which returns the edited copy for the selected preset, so it never found a change (automatic sending had the same bug). It now compares with the selected (saved) preset, lives in the spool detail and acts on the preset picked there. With no unsaved edits it says so, and for a linked preset it sends the saved settings that differ from Spooler's. Closes #38
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for #38: Send to Spoolman
edited_changes()compared the edited preset withfilaments.find_preset(edited.name). For the selected preset, OrcaSlicer'sfind_preset()returns the edited copy itself (PresetCollection::preset(idx, real=false), Preset.hpp), so the comparison never found a change. Automatic sending of edits had the same bug. It now compares withget_selected_preset(), the saved preset the edited copy was made from.Link a spool to your own preset (the reporter's suggestion; same convention as u1control#11)
orca_filament_presetis a Spoolman text extra field holding the preset name, JSON-encoded like every extra value. It is read from the spool first, then from its filament.profile_for_spool()answers the linked name, so Load Printer Filaments and Keep Slots Synced pick your preset.Test plan
ruff check plugin scripts tests,scripts/check_version.pytests/test_preset_link.pycovers field parsing (including JSON null, bool, list and dict), the spool-then-filament fallback, skipping linked presets in Sync Presets, the linked preset being picked for slots, and sending on the picked preset (unsaved edits, another preset left alone, nothing to send, saved settings of a linked preset). It also checks that presets are read on the UI thread and sent off it, and covers the editor's field creation, save and clear.PresetCollectionintest_send.pynow behaves like OrcaSlicer (find_preset()returns the edited copy). The old fake hid the bug.Closes #38