Repository navigation
feat: use the brand tile as the plugin icon - #53
Merged
Merged
Conversation
OrcaSlicer draws the Pages tab icon from the file get_icon() returns, 20 px high, loading name.svg before name.png. The tab icon is now the store tile at 40x40 (assets/spooler-plugin-icon.png, white surround made transparent), embedded as TAB_ICON_PNG and written as spooler-icon.png, a new name so the spooler_tab.svg older versions left behind does not win. It replaces the inline white spool SVG. Bumps the version to 0.29.1.
# Conflicts: # ui/package-lock.json
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/orca-cloud/spooler-tile.png) at 40x40, white surround made transparent:assets/spooler-plugin-icon.png(3.1 KB).plugin/spooler/spooler_any.py: the inline white spoolTAB_ICON_SVGis replaced byTAB_ICON_PNG(base64 of that file);icon_path()writes it to the data folder asspooler-icon.png..svgbefore.png(PluginPages::create_page->create_scaled_bitmap, 20 px high), so thespooler_tab.svgolder versions wrote would otherwise still win.release.ymlcopiesassets/orca-cloud/spooler-tile.pngtospooler-store-image.png) already is the tile; unchanged. The page header mark is unchanged.# version,PLUGIN_VERSION,ui/package.json,ui/package-lock.json), CHANGELOG: "Changed: the plugin icon is the new brand tile."Test plan
python scripts/check_version.py,python scripts/build.pynpm ci && npm run buildinui/:spooler_any.pyandui/build.jsonunchanged after the buildruff check plugin scripts testsWORKERS=1 python -m unittest discover -s tests, including the newtests/test_icon.py: 40x40, transparent corners, dominant colour equals the tile's band colour, white mark present, embedded bytes equal the asset,icon_path()writes them