Skip to content

feat(desktop): edit Device aliases with retained prompt ownership - #474

Draft
bloodf wants to merge 3 commits into
recovery/beans-device-aliases-20261106from
recovery/beans-desktop-aliases-20261106
Draft

bloodf wants to merge 3 commits into
recovery/beans-device-aliases-20261106from
recovery/beans-desktop-aliases-20261106

Conversation

@bloodf

@bloodf bloodf commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Add Rename to known Devices in the Windows/Linux Solid settings pane. The sheet calls device.set_name; blank input resets to machine_name. Demo behavior preserves the underlying machine name too.

The prompt retains account, connection, snapshot and selected Device ownership. Cancel, selection changes and authority changes close it, and late results cannot display errors in a replacement view. Current failures keep the proposed name visible. This composes the useful a13ca0c changes with current settings and generated host bindings.

Validation:

  • Desktop typecheck passed with real MyGo-generated bindings.
  • Full suite: 111 unit tests passed, 630 assertions; all 9 Chromium consumer invocations passed.
  • New mounted production SettingsPage/SheetHost consumer uses the real AppStore with synthetic transport: exact blank-reset RPC, pending-submit guard, retained refusal draft, cancel, target selection, reconnect, account A→B→A, and stale-error/admission rejection.
  • Architecture budgets/links and whitespace passed. Changed source and synthetic fixtures reviewed; credential-pattern scan found no matches.

Stacked on #473 (recovery/beans-device-aliases-20261106). Its rollout limitation applies: all roster-writing Devices need an alias-aware core. Hosted CI will be dispatched; keep Draft pending results. Browser validation does not establish installed native acceptance. Original files remain preserved; no merge, deployment or cleanup.

@vercel

vercel Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
beans Ready Ready Preview Nov 7, 2026 5:57pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 979de5c9 Deployed Nov 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant