Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intervals such as
every 9223372036854775807dcan overflow conversion to seconds, and a valid interval added to a timestamp near i64::MAX can overflow its next firing. Use checked multiplication to reject oversized input and checked addition to return no next firing when the timestamp is unrepresentable. Keep the five-minute minimum, 366-day maximum and current scheduling authority unchanged.Recovers isolated arithmetic from the legacy schedule work (
fe0b79bf1c306271519237d29f73df5f2a81d064and3afacb5b). The follow-up extends this existing draft rather than creating a duplicate routine PR. Original source remains preserved; timezone, missed-run policy and roster pending-intent changes are excluded because they need composition with the task-store authority.Validation at
df9b8fde1e84cbd221580d01ab4cfb2d8905e2cd: all six schedule tests passed using default CLI features; docs budgets/links and whitespace passed. Tests cover maximum i64 minute/hour/day inputs, an input that would wrap to one day in release arithmetic, accepted 366-day/rejected 367-day boundaries, and next-firing timestamp limits. A negative control on main with the two new regressions failed on multiplication and addition overflow; both pass with the recovered fixes. Changed source and docs were reviewed and a credential-pattern scan found no matches.Hosted CI passed for the previous head
21b634873199374c9150a5054aee5429a61febe7; results for this updated head are pending and must be checked separately. Commits were created through the GitHub API and are unsigned. Draft only; no merge or deployment.