Repository navigation
test(relay): await the unsigned request's own refusal - #459
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bloodf
marked this pull request as ready for review
November 7, 2026 21:52
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unsigned-request regression previously waited for an unrelated response. Runner requests execute in independent tasks, so that response could arrive before the planted request was handled.
The test now waits for the planted request's own response, checks its ID and
Unsigned requesterror, and confirms that no server was saved. Existing assertions are retained.Validation: independent source review approved head 943909b; the fixture and request handlers remain unchanged in the subsequent main integration. The relay binary build passed on ccb6529 with unchanged production inputs. The changed fixture is an integration test and is deferred under the current test policy. No separate affected unit test was identified for this test-only change. Clippy is unavailable and was not run. Hosted checks on the new head remain pending. Hardware is not run.
The separate admission flock history remains FAIL/UNKNOWN; diagnosis 466 did not reproduce it in one plus two units and does not establish a fix.