Skip to content

[P3][Memory-Retrieval] Complete phone memory gap assessment and acceptance #103

Open

Description

@bloodf

User outcome

A written gap list says exactly which shared memory-control behaviors the existing phone pages already satisfy.

Metadata

  • Phase: P3 · Kind: leaf · Priority: personal computers stay first; this stream is independent of VM UI work
  • Readiness: discovery — phone pages already exist; assessment first, no rebuild
  • Relative size: S/M

Current behavior and evidence

docs/architecture/phone-app.md lists Memory services pages: DM Details › Memory (recall/capture draft, explicit save/search/inspect/reflect, delivery queue, fenced deletion, capability-driven backend panels) and account connections/embedding profile pages under app/chat-info/memory/, app/settings/memory/ and src/core/memoryService.ts. They exist; this issue does not rebuild them. Implementation depth beyond that doc is unverified until read.

Proposed incremental behavior and reuse anchors

Run the same control checklist used by the macOS and desktop issues against the phone pages (code read plus fixture transport). Output: table of each behavior as satisfied / partial / missing with file references. Create separate small issues only for confirmed gaps.

License and dependency constraints

Native Beans work under the repository's GPL-3.0-only licence; no new dependency.

Ordered tasks and subtasks

  • 1. Read phone memory pages and memoryService.ts wrapper
  • 2. Fill the checklist table
  • 3. Open child issues for each confirmed gap, parented to epic-memory-retrieval

Affected surfaces

  • mobile/app/chat-info/memory
  • mobile/app/settings/memory
  • mobile/src/core/memoryService.ts

Failure, security, privacy and data-preservation cases

  • Do not report an unread behavior as satisfied.

Acceptance

  • Checklist table covers every control in the macOS issue's acceptance list
  • Each missing item has a linked issue
  • No existing page is rewritten by this issue

Verification

  • Automated: No established automated command covers this discovery; evidence is the written decision record.
  • Manual scenario: Review the table against the phone UI on a device.
  • Plain-language note: commands above were not executed during roadmap drafting; run only those relevant to the change.

Prerequisites

Blocked by: none.

Completion evidence

  • Linked PR with passing checks listed above
  • Manual scenario result recorded (date, platform, outcome)
  • Affected docs/architecture/*.md updated in the same change; bun run check:docs passes

Current delivery phase

P3 — Profiles memory and artifacts. This difficulty-first assignment supersedes earlier phase/priority wording. Explicit dependencies remain required; same-phase work follows dependency order. Stable keys (including p0-* keys) remain unchanged.

Managed roadmap links

Parent: [P3][Epic] Memory retrieval: evidence on top of the existing foundation
Blocked by: None.

Scope and acceptance alignment

The recorded phone assessment and fixture results are the baseline. #329 owns shared-form accessible names and #330 owns phone memory English/Chinese localization; do not duplicate those changes here. This ticket reconciles their results and actual phone/device acceptance. Draft #356 currently has zero published changed files and is a reservation, not evidence that the gaps are fixed.

Existing PR review — 2026-10-19

Draft #356 remains open at 3becca79d270fd31b93b743831d134eb58068906 with zero changed files, also verified against current main 4760281f2b9cb24eec4438a473e7226cd4e3980c. It is a reservation, not a completed implementation or a ready merge. No acceptance boxes were checked and no feature/runtime result was inferred. Existing historical assessments retain their original revisions and limitations. Resume only with a bounded result and preserved unpublished work; phase, labels, dependencies and Project fields remain unchanged.

Activity

  1. added
    roadmapManaged Beans capability roadmap
    phase:P4Roadmap phase P4; not a blanket dependency
    area:memoryBeans memory workstream
    on Oct 7, 2026
  2. changed the title [-][P4][Memory-Retrieval] Assess phone memory pages against the shared fixture and close gaps[/-] [+][P3][Memory-Retrieval] Assess phone memory pages against the shared fixture and close gaps[/+] on Oct 7, 2026
  3. added
    phase:P3Roadmap phase P3; not a blanket dependency
    readyReady to pick: prerequisites met, owner free
    and removed
    phase:P4Roadmap phase P4; not a blanket dependency
    on Oct 7, 2026
  4. bloodf commented on Oct 13, 2026

    @bloodf
    OwnerAuthor

    Task contract — 2026-10-13

    • Readiness: ready. none found; the phone pages exist (chat-info/memory/[id].tsx, advanced.tsx, setup.tsx; settings/memory/connection.tsx, embedding.tsx).
    • Depends on: none. Successors: [P3][Epic] Memory retrieval: evidence on top of the existing foundation #16, [P3][Memory-Retrieval] Show source and age of recalled evidence #104.
    • Source area: mobile/app/chat-info/memory/, mobile/app/settings/memory/, mobile/src/core/memoryService.ts
    • Current owner: unassigned; a worker claims it by commenting its branch and name here
    • Next action: Read mobile/src/core/memoryService.ts and the pages under mobile/app/settings/memory and fill the control checklist table.
    • Acceptance: Checklist table covers every control in [P3][Memory-Retrieval] Complete macOS memory controls and acceptance #101's acceptance list with satisfied/partial/missing and file references; each missing item has a linked child issue; no existing page rewritten.
    • Flow: focused check in an isolated target, one independent review, PR with -R bloodf/beans, merge by the publishing authority, post-merge check. Source PASS is not installed-app or live-service acceptance.
  5. bloodf commented on Oct 13, 2026

    @bloodf
    OwnerAuthor

    Claimed: branch roadmap/p3/ship103-phone-memory (from 138245f), worker: heitor's session. Source area: mobile/app/chat-info/memory, mobile/app/settings/memory, mobile/src/core/memoryService.ts. Assessing phone pages against #101 checklist.

  6. bloodf commented on Oct 13, 2026

    @bloodf
    OwnerAuthor

    Phone memory pages vs #101 acceptance — assessment (branch roadmap/p3/ship103-phone-memory @ 138245f, code read + bun test mobile/src/core/memoryService.test.ts memoryAdvanced.test.ts src/ui/memoryDeletion.test.ts: 32 pass). No source changed; no page rewritten. Not checked on a device.

    #101 control Status Evidence
    Connection with keep/replace/clear secret patches satisfied app/settings/memory/connection.tsx (MemorySecret, endpoint/HTTP-policy keep/replace/clear, OpenViking per-bot patches), memoryService.ts secretPatch; test "secret bytes preserved; omitted endpoint/options keep them private"
    Bind bot + enable recall with consent approvals satisfied app/chat-info/memory/[id].tsx Connection menu, Automatic recall, "Approve Exact Recall/Capture Choices", group-capture approval; capture off by default, unattended refused (MemoryPreferencesDraft)
    Changing connection clears consent approvals satisfied MemoryPreferencesDraft.connectionID setter; test "connection changes invalidate prior plaintext and group approval"
    Missing capability disables rather than hides partial Basic actions (retain/recall/reflect/inspect/delete/operations) stay visible and disabled with a reason (MemoryAction). Advanced feature links are hidden when no negotiated verb exists — documented design in phone-app.md/memory-ui.md ("absent or empty action lists hide them"), so no child issue
    Health, delivery_unknown, delete-pending distinguishable satisfied [id].tsx Service state / Readiness reason / "Delivery unknown — not confirmed stored" / "Deletion pending" / "Pending cleanup"; memoryDeletion.test.ts
    Every control has an accessible name partial Rows, actions and menus are named. ToggleRow <Switch> and FieldRow <TextInput> (src/ui/forms.tsx) have no accessibilityLabel; pages use them for recall/capture toggles, budgets, caps, endpoint/secret/binding/embedding fields → child #329
    Embedding profile editor satisfied settings/memory/embedding.tsx
    Delivery queue, fenced deletion, setup previews satisfied [id].tsx, memoryDeletion, chat-info/memory/setup.tsx, settings/memory/local-setup.tsx
    EN + zh-Hans strings (#101 task 5, not in its acceptance list) missing memory pages hard-coded English; src/i18n/zh.ts has no memory keys → child #330

    Child issues (parented to #16): #329 (accessible names, fix is in shared forms.tsx, outside this issue's owned paths), #330 (localization). Native/device manual scenario still outstanding.

  7. changed the title [-][P3][Memory-Retrieval] Assess phone memory pages against the shared fixture and close gaps[/-] [+][P3][Memory-Retrieval] Complete phone memory gap assessment and acceptance[/+] on Oct 19, 2026
  8. added
    priority:normalUrgency: normal; schedule after high-priority work. Independent of roadmap phase.
    platform:androidScope: Android; implementation and acceptance require target-specific evidence.
    platform:iosScope: iOS; implementation and acceptance require target-specific evidence.
    and removed on Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:memoryBeans memory workstreamphase:P3Roadmap phase P3; not a blanket dependencyplatform:androidScope: Android; implementation and acceptance require target-specific evidence.platform:iosScope: iOS; implementation and acceptance require target-specific evidence.priority:normalUrgency: normal; schedule after high-priority work. Independent of roadmap phase.readyReady to pick: prerequisites met, owner freeroadmapManaged Beans capability roadmaptype:discoveryRoadmap discovery

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions