Skip to content

[P3][Memory-Retrieval] Complete desktop memory controls and acceptance #102

Open

Description

@bloodf

User outcome

A desktop user configures memory connections, embedding profiles and per-bot consent and sees health and delivery state.

Metadata

  • Phase: P3 · Kind: leaf · Priority: personal computers stay first; this stream is independent of VM UI work
  • Readiness: ready — core and TypeScript adapters exist; sheet attachment is the gap
  • Relative size: L

Current behavior and evidence

Per docs/architecture/memory-ui.md, the Foundation/TypeScript adapters exist and native account/per-bot controls are not attached on macOS and desktop; the memory service core already exists and is not rebuilt here. Desktop AppStore.memoryRequest forwards only the exact RPC allowlist; General's Memory action calls presentMemoryConnections; the sheet module is not attached.

Proposed incremental behavior and reuse anchors

Attach desktop/src/model/memoryService.ts and memorySetup.ts to Solid sheets with the same control set and rules as the macOS issue.

License and dependency constraints

Native Beans work under the repository's GPL-3.0-only licence; no new dependency.

Ordered tasks and subtasks

  • 1. presentMemoryConnections sheet
  • 2. Embedding profile sheet
  • 3. Per-bot consent controls
  • 4. Status/queue/deletion views
  • 5. Accessibility and strings
  • 6. Update docs/architecture/memory-ui.md

Affected surfaces

  • desktop/src
  • desktop/src/model/memoryService.ts
  • desktop/src/model/memorySetup.ts
  • docs/architecture/memory-ui.md

Failure, security, privacy and data-preservation cases

  • memoryRequest rejects arbitrary methods and demo mode; keep that.
  • Secrets never echo back.
  • Unattended capture refused.

Acceptance

  • Create a connection with keep/replace/clear patches
  • Enable recall for a bot with consent approvals
  • Changing connection clears approvals
  • Missing capability disables the control
  • Status states distinguishable
  • Keyboard and screen-reader operation

Verification

  • Automated: Future-only (none run while drafting): bun test desktop/src/model/memoryService.test.ts desktop/src/model/memorySetup.test.ts, bun run check:docs
  • Manual scenario: On desktop configure a fixture connection and enable recall for one bot.
  • Plain-language note: commands above were not executed during roadmap drafting; run only those relevant to the change.

Prerequisites

Blocked by: none.

Completion evidence

  • Linked PR with passing checks listed above
  • Manual scenario result recorded (date, platform, outcome)
  • Affected docs/architecture/*.md updated in the same change; bun run check:docs passes

Current delivery phase

P3 — Profiles memory and artifacts. This difficulty-first assignment supersedes earlier phase/priority wording. Explicit dependencies remain required; same-phase work follows dependency order. Stable keys (including p0-* keys) remain unchanged.

Managed roadmap links

Parent: [P3][Epic] Memory retrieval: evidence on top of the existing foundation
Blocked by: None.

Scope and acceptance alignment

Current memory-ui.md and desktop-app.md document the implemented Solid/native memory controls. The remaining work is parity and platform acceptance, not attaching a new sheet from scratch. Draft #346 contributes English/Chinese status and delivery labels after merged #331; it is distinct from phone localization #330. Preserve exact-head checks and actual Windows/Linux evidence as completion requirements.

Activity

  1. added
    roadmapManaged Beans capability roadmap
    phase:P4Roadmap phase P4; not a blanket dependency
    area:memoryBeans memory workstream
    on Oct 7, 2026
  2. changed the title [-][P4][Memory-Retrieval] Attach memory-service controls in the Windows/Linux desktop app[/-] [+][P3][Memory-Retrieval] Attach memory-service controls in the Windows/Linux desktop app[/+] on Oct 7, 2026
  3. added
    phase:P3Roadmap phase P3; not a blanket dependency
    readyReady to pick: prerequisites met, owner free
    and removed
    phase:P4Roadmap phase P4; not a blanket dependency
    on Oct 7, 2026
  4. bloodf commented on Oct 13, 2026

    @bloodf
    OwnerAuthor

    Task contract — 2026-10-13

    • Readiness: ready. none found; desktop already ships MemoryConnectionsSheet via presentMemoryConnections in desktop/src/ui/sheets/memoryService.tsx, so remaining work is gap closure against the acceptance list.
    • Depends on: none. Successors: [P3][Epic] Memory retrieval: evidence on top of the existing foundation #16, [P3][Memory-Retrieval] Show source and age of recalled evidence #104.
    • Source area: desktop/src/ui/sheets/memoryService.tsx, desktop/src/ui/sheets/memorySetup.tsx, desktop/src/model/memoryService.ts, desktop/src/model/memorySetup.ts
    • Current owner: unassigned; a worker claims it by commenting its branch and name here
    • Next action: Audit desktop/src/ui/sheets/memoryService.tsx against the six acceptance items and implement whichever (embedding profile sheet, consent clearing, status views) is missing.
    • Acceptance: Create a connection with keep/replace/clear patches; enable recall with consent approvals; changing connection clears approvals; missing capability disables control; status states distinguishable; keyboard and screen-reader operation; bun test desktop/src/model/memoryService.test.ts desktop/src/model/memorySetup.test.ts.
    • Flow: focused check in an isolated target, one independent review, PR with -R bloodf/beans, merge by the publishing authority, post-merge check. Source PASS is not installed-app or live-service acceptance.
  5. changed the title [-][P3][Memory-Retrieval] Attach memory-service controls in the Windows/Linux desktop app[/-] [+][P3][Memory-Retrieval] Complete desktop memory controls and acceptance[/+] on Oct 19, 2026
  6. added
    priority:highUrgency: high; next important delivery or correctness work. Independent of roadmap phase.
    on Oct 19, 2026
  7. added
    platform:linuxScope: Linux; implementation and acceptance require target-specific evidence.
    platform:windowsScope: Windows; implementation and acceptance require target-specific evidence.
    on Oct 19, 2026
  8. bloodf commented on Oct 19, 2026

    @bloodf
    OwnerAuthor

    Engineering review update — PR #346

    Pushed 93eab68 restores the lost memory delivery-label regression using the actual shared presentation helpers. English/Chinese label and model/setup tests: 26 passed, 120 assertions. Docs/whitespace pass. Locked install and MyGo generation pass; full desktop typecheck passes after composing the existing main typing fixes. Raw Bun JSX desktop tests still fail in the shared harness tracked through #371/#373. Whole l10n remains non-green on 14 unrelated unused keys (current main has those plus Stored). Windows/Linux installed-app and assistive-technology acceptance remain unverified.

    The PR remains open as Draft. This evidence does not complete this issue or its platform acceptance. Existing phase, labels and dependencies are preserved; shared aggregate exact-head CI acceptance remains #373.

    Full-PR whitespace audit found and removed a trailing blank line in memoryLabels.ts. Fresh immutable receipts on this head record docs, full-PR whitespace, desktop typecheck and 26 focused tests passing. Earlier whitespace checks covered only the working delta.

  9. bloodf commented on Oct 19, 2026

    @bloodf
    OwnerAuthor

    PR #346 now has reviewed repair head 08e10c4f04bc990240f92971bb1740411ec5da52 pushed normally, preserving branch history. Its minimal shared CI prerequisites are integrated.

    Published head: 08e10c4f04bc990240f92971bb1740411ec5da52. Immutable command/head/exit/log-hash receipts record: 26 focused memory label/model/setup tests, full desktop: 110 unit tests/639 assertions and 8 actual Chromium invocations across 7 consumers. Desktop TypeScript and docs/catalog/full-PR whitespace.

    Browser/unit evidence does not establish installed Windows/Linux shell or standalone Web acceptance. Remaining unrelated localization diagnostics are retained in the ledger.

    This head is now pushed and remains Draft. Its own required hosted checks must complete successfully before a readiness decision; queued or running checks are not passes. Canonical shared checks informed integration but do not replace this PR's final-head matrix. No merge, auto-merge or deployment is requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:memoryBeans memory workstreamphase:P3Roadmap phase P3; not a blanket dependencyplatform:linuxScope: Linux; implementation and acceptance require target-specific evidence.platform:windowsScope: Windows; implementation and acceptance require target-specific evidence.priority:highUrgency: high; next important delivery or correctness work. Independent of roadmap phase.readyReady to pick: prerequisites met, owner freeroadmapManaged Beans capability roadmaptype:implementationRoadmap implementation

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions