Skip to content

test: salvage telemetry route boundary tests and local CI coverage note - #108

Merged
bloodf merged 4 commits into
mainfrom
test/salvage-telemetry-routes
Nov 12, 2026
Merged

bloodf merged 4 commits into
mainfrom
test/salvage-telemetry-routes

Conversation

@bloodf

@bloodf bloodf commented Nov 12, 2026

Copy link
Copy Markdown
Owner

What

Salvaged from unmerged work (PR #95 / t3/telemetry-route-tests, t3/local-ci-scope-note):

  • tests/node/telemetry-routes.test.ts: both /api/connector/telemetry and /api/connector/telemetry/challenge routes enforce the boundary (400) before the runtime, return 503 when the runtime is absent, and forward runtime responses. Route names verified against current code; added a type cast so root tsc passes.
  • docs/LOCAL-CI.md: state that check:all/the code job skip the farm-view Playwright cases and the packages/webrtc-experiment scripts, with pnpm commands (original text said bun).

Why

Not on main; no runtime changes.

Commands run

  • Mac: node --test tests/node/telemetry-routes.test.ts 2 pass / 0 fail; tsc --noEmit pass; prettier clean on changed files.
  • cortexos (head df0afaf): typecheck pass; test:rtsp-supervisor 7/7; test:rtsp-framing 66/66; build pass; test:node 784/790-ish pass, 1 fail; test (vitest) 5 failures in tests/unit/moonraker-collect.test.ts. Failures are in files this PR does not touch; telemetry-routes passed.
  • pnpm run lint fails on main already: prettier warns on scripts/vercel-ignore.mjs and scripts/test-vercel-ignore.mjs (not touched here).

Not run

Playwright e2e, Docker/simulator checks (no relevance to a test/docs change).

@bloodf
bloodf marked this pull request as ready for review November 12, 2026 01:05
@bloodf
bloodf merged commit 8242a89 into main Nov 12, 2026
@bloodf
bloodf deleted the test/salvage-telemetry-routes branch November 16, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant