Repository navigation
test: salvage telemetry route boundary tests and local CI coverage note - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Salvaged from unmerged work (PR #95 / t3/telemetry-route-tests, t3/local-ci-scope-note):
tests/node/telemetry-routes.test.ts: both/api/connector/telemetryand/api/connector/telemetry/challengeroutes enforce the boundary (400) before the runtime, return 503 when the runtime is absent, and forward runtime responses. Route names verified against current code; added a type cast so roottscpasses.docs/LOCAL-CI.md: state thatcheck:all/the code job skip the farm-view Playwright cases and thepackages/webrtc-experimentscripts, with pnpm commands (original text said bun).Why
Not on main; no runtime changes.
Commands run
node --test tests/node/telemetry-routes.test.ts2 pass / 0 fail;tsc --noEmitpass; prettier clean on changed files.test:node784/790-ish pass, 1 fail;test(vitest) 5 failures in tests/unit/moonraker-collect.test.ts. Failures are in files this PR does not touch; telemetry-routes passed.pnpm run lintfails on main already: prettier warns on scripts/vercel-ignore.mjs and scripts/test-vercel-ignore.mjs (not touched here).Not run
Playwright e2e, Docker/simulator checks (no relevance to a test/docs change).