fix(governance): drep_id param is Bech32 only, not hexadecimal - #470
Merged
Merged
Conversation
All /governance/dreps/{drep_id}/* endpoints validate the parameter with
validateDRepId, which decodes Bech32 (legacy drep1/drep_script1 or
CIP-129) and returns 400 for hex input, so the descriptions claiming
hexadecimal is accepted were wrong.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
drep_idpath parameter on all five/governance/dreps/{drep_id}/*endpoints was described as "Bech32 or hexadecimal DRep ID.", but the backend validates it withvalidateDRepId, which only decodes Bech32 (legacydrep1.../drep_script1...or CIP-129) and returns 400 "Invalid or malformed drep id." for hex input. Updated to "Bech32 DRep ID (legacy or CIP-129)."The pool endpoints' "Bech32 or hexadecimal pool ID." descriptions are untouched, hex is genuinely accepted there.
🤖 Generated with Claude Code