Repository navigation
Replace changed section bands with quiet dots - #249
HamptonMakes wants to merge 7 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af30bc508b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd8b853ad4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🤖 @codex review — both remaining findings are addressed in bc9c7f2. New and renamed sections are tracked, Dismiss allows genuinely newer material to restore attention, and extensive rewrites keep one summary. The focused specs pass (86 examples). I also fixed the mobile spec leaking its viewport into later tests; the mobile check followed by the three composer regressions now passes. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc9c7f231c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🤖 @codex review — the notice no longer causes reflow (11ef7da), with a regression in both themes and at desktop and narrow widths. I also corrected the last-visit comparison to use the newest read version rather than the association’s default oldest-first order, with request coverage. All four prior review threads have fixes and replies. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dddb563add
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Hampton Lintorn-Catlin <hampton@squareup.com>
Signed-off-by: Hampton Lintorn-Catlin <hampton@squareup.com>
1 participant
What changed and why
Changed sections currently draw blue bands through prose, code, tables, and diagrams. Large edits make the document hard to scan.
Replace those bands with small orange dots beside changed headings. Hover or keyboard-focus a dot to see the last editor and relative and exact update times. Dots clear after three seconds in view; hovering or focusing keeps them available. A newer edit brings its dot back, including newly added or renamed sections. Dismiss acknowledges the current updates; later material can restore attention. A compact notice offers History and Dismiss. On phones, the notice has padded rows and the document gutter keeps each dot’s full hit area inside the card. Extensive changes get one notice instead of dots throughout the page.
The comparison uses the most recent version the reader saw. Section attribution follows the most recent edit to that section, including live updates. The notice reserves its space so live updates never push the document down. Presentations keep their current content until the show ends, then show every queued section update with its own editor. After dismissing an extensive-update notice, later ordinary edits get fresh dots. The markers remain specific to each viewer, and authored text and layout stay unchanged.
Evidence
Dark theme:
Light theme:
Mobile, at 481 pixels, in both themes:
How to try it
Local preview: http://127.0.0.1:3046/hampton/update-markers-mixed-content#design
Testing
DATABASE_URL=mysql2://root@localhost/coplan_update_markers_315d_test bundle exec rspec. Full MySQL and PostgreSQL CI suites passed ond3e6cc5. CI is rechecking the mobile spacing fix.DATABASE_URL=mysql2://root@localhost/coplan_update_markers_315d_test bundle exec rspec spec/system/changed_sections_ux_spec.rb spec/system/comment_composer_spec.rb spec/services/broadcaster_spec.rb spec/requests/changed_sections_highlight_spec.rb— 56 examples, zero failures. This includes the notice geometry check in both themes and at desktop and narrow widths.DATABASE_URL=mysql2://root@localhost/coplan_update_markers_315d_test bundle exec rspec spec/requests/changed_sections_highlight_spec.rb spec/services/plans/section_updates_spec.rb— 11 examples, zero failures, including the corrected read baseline. The final marker and presentation browser checks passed: 20 examples, zero failures. Both affected spec files pass RuboCop. Mobile gutter, notice padding, tooltip visibility, and overflow checks pass at 320, 390, and 481 pixels in both themes. The live-notice geometry check also passes. No database migrations or API changes.Generated with Codex