desktop: polish sidebar search dialog#1155
Merged
Merged
Conversation
Collaborator
Author
ScreenshotsChannel headerThe channel header is flush with the content area; the empty top chrome strip is gone.
Sidebar search dialogThe sidebar search trigger opens a centered command-style dialog.
|
Co-authored-by: Wes <wesbillman@users.noreply.github.com> Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
force-pushed
the
pinky/header-search-polish
branch
from
df61bda to
ea2f1d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
./bin/pnpm --dir desktop typecheck./bin/pnpm --dir desktop check./bin/pnpm --dir desktop build./bin/pnpm --dir desktop exec playwright test --project=smoke tests/e2e/smoke.spec.ts -g "search|collapsed sidebar"(6 passed)./bin/just desktop-screenshot --name channel-general --active-channel general --outdir test-results/screenshots/header-search-polish./bin/just desktop-screenshot --name search-dialog --click open-search --outdir test-results/screenshots/header-search-polish