Repository navigation
Conversation
cc62545 to
da76011
Compare
4711adc to
836de40
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
v1 Agents is gone, so Agents2 takes the plain name: `features/agents2` and `bundled/agents2` move into `features/agents` and `bundled/agents`, the plugin is `buzz.agents` with page `agents`, the injected service is `agents`, and types, hooks, docs and labels drop the 2. Saved data keeps the Agents2 names, so existing agents carry over and earlier builds running alongside still find them: the `agents2/identities.json` app data folder and the `buzz.agents2.v1` and `buzz.agents2.teams.v1` local storage keys. The plugin's on/off switch stays under `buzz.agents2` on desktop and web, which also keeps a leftover v1 `buzz.agents` switch from turning the new Agents off. Co-authored-by: claude00 <fb8b76a01257932b8ca35060862c29bd09b2137638573731c2d5074fc02c5385@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Bradley Axen <baxen@squareup.com>
Move identity directories and browser settings once, convert the plugin switch while discarding the retired v1 preference, and keep normal reads and writes on Agents names. Isolate temporary migration code with an October 18 removal checklist. Co-authored-by: codex00 <6922125dbee102fcf02d2b32441fd56927c1298ac16119167f82f72529d13676@buzz.block.builderlab.xyz> Signed-off-by: Bradley Axen <baxen@squareup.com>
Carry the Channels fixture wiring through the Agents rename. All 24 affected browser cases pass across Chromium and WebKit at the combined stack tip. Co-authored-by: codex00 <6922125dbee102fcf02d2b32441fd56927c1298ac16119167f82f72529d13676@buzz.block.builderlab.xyz> Signed-off-by: Bradley Axen <baxen@squareup.com>
836de40 to
fc6c53d
Compare
d46c23d to
6eacd13
Compare
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
One change needed: make frontend settings-migration failures visible and recoverable instead of leaving startup on “Opening Buzz” (P2, inline).
Star Lord’s automated source review via Wes’s account. Reviewed head 6eacd1336a798fa991b0937866bedaac2573fe3f against base fc6c53d9ce172ad83b2ccb5e73f2370b26937e83. Source-only: no tests, builds, CI verification, or app execution; existing-profile migration and native GUI/Windows acceptance remain unverified.
| super(ctx, "agents2"); | ||
| super(ctx, "agents"); | ||
| this.contributions = createContributions<AgentType>(ctx); | ||
| migrateAgentStorage(storage); |
There was a problem hiding this comment.
[P2] Surface migration failures before aborting application startup
A failed localStorage copy (for example, quota exhaustion while both copies must coexist), or the explicitly supported conflicting-destination case, throws from this constructor. createServices() does not catch it, and src/main.tsx:19–25 calls that function before creating/rendering the React root. Consequently the user stays on the static “Opening Buzz” screen; the error and recovery controls never render, and reopening repeats the failure. The plugin RecoveryScreen cannot handle this path because the app has not mounted. Keep the non-overwrite/source-preservation behavior, but catch and present this migration failure through a startup recovery surface with an actionable retry/restart path. Add a startup-level regression test for a throwing migration; the helper-only assertions currently verify the throw but miss the unusable app.
baxen
changed the title
2 participants
Top of the agents merge stack: #838 → #855 → #856 → #858 → #859 → #860 → #865 → #867 → this PR.
With v1 Agents removed, Agents2 becomes Agents in the UI, code, and saved data. Existing identities, settings, teams, and the plugin enable/disable preference carry over on first launch.
Changes
src/features/agents2andsrc/bundled/agents2, the injected service, types, hooks, labels, and plugin/page identifiers to Agents. The page key becomesbuzz.agents/agents.agents2/identities.jsontoagents/identities.jsonusing an atomic directory rename under Buzz's existing exclusive instance lock. Identity bytes and keychain identities are unchanged. Conflicting folders or another running Buzz copy stop migration without replacing data.buzz.agents.v1andbuzz.agents.teams.v1. Copy before deleting the source; resume identical interrupted copies and refuse conflicting destinations.buzz.agents, discarding the retired v1 switch. Native registry v2 and browser settings v3 make this conversion one-time and preserve later preference changes.docs/agents.mdfor October 18, after development users upgrade.This is a one-way development migration. Close older Buzz copies before the first upgraded launch and use the upgraded build afterward. Cosmetic page-key state (search ranking, custom shortcut, saved view state) does not migrate.
Validation
6eacd1336, all 24 affected browser cases pass in Chromium and WebKit (48.2s locally); the fixtures use the renamed Agents dependency.