Repository navigation
Redesign agent creation and library #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
klopez4212
wants to merge
23
commits into
main
Choose a base branch
from
kennylopez-agents-layout-avatars
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11,237
−1,975
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0598941
Redesign agent library and creation with avatars and voice instructions
klopez4212 d3374b2
Merge main while preserving agent creation and import workflows
klopez4212 d73c7d3
Validate redesigned agent workflows and add preview snapshots
klopez4212 149f59a
Fix agent settings regression test import
klopez4212 2d4f8d0
Update profile and icon coverage for agent redesign
klopez4212 7bfa0fd
Keep quick model feedback inside the floating picker
klopez4212 5c54ffe
Merge main and reconcile duplicate agent fixture methods
klopez4212 caba96a
Fix agent configuration interactions and update browser journeys
klopez4212 7a67069
Route Codex card configuration through the full editor
klopez4212 0df5e24
Wait for member list transition in rejection recovery test
klopez4212 adbadb0
Require explicit application of voice instruction drafts
klopez4212 aa9b5c8
Fix agent creation dismissal and shared control boundaries
klopez4212 c869e09
Keep agent recovery controls reachable during setup
klopez4212 d692922
Wait for current model authentication message in test
klopez4212 50d0b5e
Recover shared-agent browse reads from byte limits
klopez4212 f781764
Use supported role query options in browse regression
klopez4212 ce6cbda
Keep catalog byte-budget regression focused on reads
klopez4212 b2b536d
Preserve agent setup recovery and shared focus boundaries
klopez4212 40a68bc
Finish recovered agent setup and bundle native avatar codecs selectively
klopez4212 09694d6
Use explicit extension for native Vite config loading
klopez4212 5f3f82a
Fix remaining agent model and instruction focus findings
klopez4212 5d545e6
Verify pinned native speech archives before linking
klopez4212 f09a9d3
Exercise instruction recording through the real React hook
klopez4212 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| [workspace] | ||
| members = ["crates/pairing", "crates/plugin-manager", "crates/agent-controller", "crates/credential-store", "src-tauri"] | ||
| members = ["crates/pairing", "crates/plugin-manager", "crates/agent-controller", "crates/credential-store", "src-tauri", "vendor/sherpa-onnx-sys"] | ||
| default-members = ["crates/plugin-manager"] | ||
| resolver = "2" | ||
|
|
||
| [patch.crates-io] | ||
| sherpa-onnx-sys = { path = "vendor/sherpa-onnx-sys" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { build } from "vite"; | ||
| import { expect, it } from "vitest"; | ||
| import { avatarCodecs } from "./avatar-codecs"; | ||
|
|
||
| it.each([ | ||
| ["macos", 0, 49], | ||
| ["windows", 49, 0], | ||
| ["linux", 49, 0], | ||
| [undefined, 49, 49], | ||
| ] as const)( | ||
| "emits only supported native avatar codecs for %s", | ||
| async (platform, webm, mp4) => { | ||
| const result = await build({ | ||
| configFile: false, | ||
| logLevel: "silent", | ||
| plugins: [avatarCodecs(platform)], | ||
| build: { | ||
| write: false, | ||
| minify: false, | ||
| assetsInlineLimit: 0, | ||
| rollupOptions: { | ||
| input: "src/features/agents/avatar-packs.ts", | ||
| preserveEntrySignatures: "strict", | ||
| }, | ||
| }, | ||
| }); | ||
| if (Array.isArray(result) || !("output" in result)) | ||
| throw new Error("Unexpected build result"); | ||
| const assets = result.output.filter((item) => item.type === "asset"); | ||
| expect( | ||
| assets.filter((item) => item.fileName.endsWith(".webm")), | ||
| ).toHaveLength(webm); | ||
| expect( | ||
| assets.filter((item) => item.fileName.endsWith(".mp4")), | ||
| ).toHaveLength(mp4); | ||
| expect( | ||
| assets.filter((item) => item.fileName.endsWith(".png")), | ||
| ).toHaveLength(49); | ||
| }, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import type { Plugin } from "vite"; | ||
|
|
||
| /** Keep native installs offline-capable without shipping the other engine's codec. */ | ||
| export function avatarCodecs(platform: string | undefined): Plugin { | ||
| const excluded = | ||
| platform === "macos" | ||
| ? "webm" | ||
| : platform === "windows" || platform === "linux" | ||
| ? "mp4" | ||
| : undefined; | ||
| const empty = "\0unused-avatar-codec"; | ||
| return { | ||
| name: "avatar-codecs", | ||
| enforce: "pre", | ||
| resolveId(source, importer) { | ||
| if ( | ||
| excluded && | ||
| importer | ||
| ?.replaceAll("\\", "/") | ||
| .endsWith("/features/agents/avatar-packs.ts") && | ||
| source.replaceAll("\\", "/").includes("/avatar-packs/") && | ||
| source.split("?")[0]?.endsWith(`.${excluded}`) | ||
| ) | ||
| return empty; | ||
| }, | ||
| load(id) { | ||
| if (id === empty) return "export default undefined;"; | ||
| }, | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"><dict><key>NSMicrophoneUsageDescription</key><string>Buzz uses your microphone to record voice notes you choose to send.</string></dict></plist> | ||
| <plist version="1.0"><dict><key>NSMicrophoneUsageDescription</key><string>Buzz uses your microphone for voice notes and local transcription of agent instructions.</string></dict></plist> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Verify the native speech archive before linking it
These default features enable
sherpa-onnx-sys's static build. In the pinned 1.13.4 build script,download_prebuilt_libsdownloads a platform tarball from GitHub Releases, unpacks it without checking a digest, and links its Sherpa/ONNX libraries. Cargo.lock authenticates the Rust crate, not those separately downloaded binaries. I found no verifiedSHERPA_ONNX_ARCHIVE_DIR/SHERPA_ONNX_LIB_DIRprovisioning in this repository's.github,scripts,bin, or.cargobuild paths.A replaced release asset can therefore change executable code in the signed app without any lockfile/source change. Pin the approved per-target archive digests and fail closed on mismatch before supplying the verified libraries to Cargo (including cache reuse), or build from pinned source. The version string alone does not pin these native bytes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 Fixed in 5d545e6 (hosted head f09a9d3). The workspace patches the pinned sys crate so direct and transitive Cargo builds verify approved SHA-256 pins for all five supported static archives before extraction/linking. Cached/local archives use the same verification; extracted libraries are rebuilt from verified bytes, and unverified LIB_DIR overrides fail closed. Two archive regression tests, direct build-script corruption/override probes, and mandatory type/unit, design-system, and workspace Clippy gates passed. Independent source review found no blockers. Hosted DCO passed; CI is running. Windows/native live speech acceptance remains unverified.