MB-69881: Re-architect vector search - #32
Merged
Merged
Conversation
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti,
capemox,
Copilot and
maneuvertomars
December 28, 2025 06:35
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the vector search architecture to adopt a visitor-pattern based iteration model for eligible documents in filtered vector searches. The change adapts the existing code to implement the new SegmentEligibleDocuments interface from the bleve_index_api package.
Key Changes:
- Replaced direct slice return (
SegmentEligibleDocs) with an iterator-based approach (SegmentEligibleDocuments) - Introduced
eligibleDocumentListandeligibleDocumentIteratortypes to support the new visitor pattern - Updated
VectorReaderto use the newCount()method instead of directly checking slice length
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 20947589458Details
💛 - Coveralls |
abhinavdangeti
approved these changes
Jan 16, 2026
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SegmentEligibleDocumentsinterface which allows usage of visitor-pattern based iteration of eligible documents for filtered vector search.