Skip to content

perf: import pkc-js via the slim ./client entry #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Rinse12 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

perf: import pkc-js via the slim ./client entry #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cli/base-command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Command, Flags } from "@oclif/core";
import defaults from "../common-utils/defaults.js";
import PKC from "@pkcprotocol/pkc-js";
import PKC from "@pkcprotocol/pkc-js/client";

Check failure on line 3 in src/cli/base-command.ts

View workflow job for this annotation

GitHub Actions / test-bitsocial-cli (ubuntu-latest) 

Cannot find module '@pkcprotocol/pkc-js/client' or its corresponding type declarations.

Check failure on line 3 in src/cli/base-command.ts

View workflow job for this annotation

GitHub Actions / test-bitsocial-cli (macos-latest) 

Cannot find module '@pkcprotocol/pkc-js/client' or its corresponding type declarations.

Check failure on line 3 in src/cli/base-command.ts

View workflow job for this annotation

GitHub Actions / test-bitsocial-cli (windows-latest) 

Cannot find module '@pkcprotocol/pkc-js/client' or its corresponding type declarations.
import { PKCLogger, setupDebugLogger, type PKCLoggerType } from "../util.js";
type PKCInstance = Awaited<ReturnType<typeof PKC>>;
type PKCConnectOverride = (pkcRpcUrl: string) => Promise<PKCInstance>;
Expand Down Expand Up @@ -31,7 +31,7 @@
}
const pkc = await PKC({ pkcRpcClientsOptions: [pkcRpcUrl] });
const errors: Error[] = [];
pkc.on("error", (err) => {

Check failure on line 34 in src/cli/base-command.ts

View workflow job for this annotation

GitHub Actions / test-bitsocial-cli (ubuntu-latest) 

Parameter 'err' implicitly has an 'any' type.

Check failure on line 34 in src/cli/base-command.ts

View workflow job for this annotation

GitHub Actions / test-bitsocial-cli (macos-latest) 

Parameter 'err' implicitly has an 'any' type.

Check failure on line 34 in src/cli/base-command.ts

View workflow job for this annotation

GitHub Actions / test-bitsocial-cli (windows-latest) 

Parameter 'err' implicitly has an 'any' type.
errors.push(err);
});
await new Promise<void>((resolve, reject) => {
Expand Down
Loading