Performance: chore - drop x86_64 from Android release builds - #2310
Closed
JohnathanWhite wants to merge 2 commits into
Closed
JohnathanWhite wants to merge 2 commits into
JohnathanWhite wants to merge 2 commits into
Conversation
Follows dropping 32-bit x86. x86_64 is emulator-only, so every release APK carried a full extra copy of every native library that no real device executes. The debug build type adds it back via AGP's abiFilters union, so emulator development is unaffected. Also documents why enableProguardInReleaseBuilds must stay false for now: proguard-rules.pro is empty and this app reflects heavily through bitcore/BWC, Braze, Sumsub, Dosh and Ledger, so enabling R8 needs its own change with a full QA pass.
removed Dosh reference
Collaborator
|
follow-up: JohnathanWhite#13 |
Collaborator
|
Already implemented here: #2241. We can close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows dropping 32-bit x86. x86_64 is emulator-only, so every release APK carried a full extra copy of every native library that no real device executes. The debug build type adds it back via AGP's abiFilters union, so emulator development is unaffected.
Also documents why enableProguardInReleaseBuilds must stay false for now: proguard-rules.pro is empty and this app reflects heavily through bitcore/BWC, Braze, and Sumsub so enabling R8 needs its own change with a full QA pass.