Skip to content

Add new V3 API following Prometheus spec#62

Draft
brandonchinn178 wants to merge 4 commits into
bitnomial:masterfrom
brandonchinn178:v3
Draft

Add new V3 API following Prometheus spec#62
brandonchinn178 wants to merge 4 commits into
bitnomial:masterfrom
brandonchinn178:v3

Conversation

@brandonchinn178

Copy link
Copy Markdown

Fixes #59
Fixes #39

@riz0id riz0id left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only hard feedback is about the globalRegistry

Comment thread src/System/Metrics/Prometheus/Metric.hs
Comment thread src/System/Metrics/Prometheus/Metric/Histogram.hs
Comment thread src/System/Metrics/Prometheus/Metric.hs
Comment thread src/System/Metrics/Prometheus/Metric/Counter.hs
Comment thread src/Prometheus/V3/Metric/Base.hs
Comment thread src/Prometheus/V3/MetricName.hs Outdated
Comment thread src/Prometheus/V3/Name.hs
Comment thread src/Prometheus/V3/Name.hs
Comment thread src/Prometheus/V3/Registry.hs Outdated
Comment thread src/Prometheus/V3/Registry.hs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow standard Prometheus client library API Allow non-Double Gauges

2 participants