Repository navigation
Conversation
Fee bump errors from `bdk_wallet` were collapsed into `UnknownUtxo` or `FeeRateTooLow`, so apps could not tell them apart. Add `TransactionNotFound`, `TransactionConfirmed`, `IrreplaceableTransaction`, `FeeRateUnavailable` and `InvalidOutputIndex` to `CreateTxError` and map each upstream case to its own variant. Fixes bitcoindevkit#1103
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BuildFeeBumpErrorfrombdk_wallethas six variants, but the conversion toCreateTxErrorcollapsed five of them intoUnknownUtxoorFeeRateTooLow. Txids were reported in anoutpointfield, andFeeRateUnavailablewas reported as a low fee rate, so apps couldn't tell the failures apart.This adds
TransactionNotFound,TransactionConfirmed,IrreplaceableTransaction,FeeRateUnavailableandInvalidOutputIndextoCreateTxErrorand maps each upstream case to its own variant.Fixes #1103
Notes to the reviewers
switch/whenoverCreateTxErrorexhaustively will need to handle the five new variants.FeeRateUnavailablewas previously reported asFeeRateTooLow, so code catching that variant afterBumpFeeTxBuilder.finish()will no longer see it.Displaywording, lowercased to match this file.Documentation
bdk_walletbdk_wallet::error::BuildFeeBumpErrorChangelog
changelog: breakingChecklists
All Submissions:
cargo fmtandcargo clippybefore committingchangelog:*labelBugfixes: