Repository navigation
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. External sites
ReviewsSee the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
c40de00 to
6cd9fd0
Compare
Record that an incomplete snapshot database prevents loadtxoutset until the operator removes its directory.
An interrupted snapshot load can leave a database without its base-block marker, preventing later loadtxoutset attempts. Wipe the snapshot database before opening it so callers can retry without removing the directory manually. Correct the startup warning to point at the missing marker and say that a retry replaces the directory.
6cd9fd0 to
15a891d
Compare
|
Found a simpler fix using the existing database wipe option, which lets interrupted loads be retried. |
|
Should the regression test also cover a snapshot database whose LOCK is held by another process? tACK 15a891d Tested on Linux aarch64 (Debian 13, GCC 14.2.0):
|

Problem: An interrupted
loadtxoutsetcan leave an incompletechainstate_snapshotdatabase without its requiredbase_blockhashmarker. A later call can fail to open that database, requiring the operator to remove it manually before retrying.Fix: Wipe the snapshot database before opening it so a later call can replace incomplete data. LevelDB acquires the database lock before deleting files, so a database held open by another load cannot be wiped. Also correct the startup warning to identify the missing marker and explain that retrying replaces the directory.