Repository navigation
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process. LLM Linter (✨ experimental)Possible typos and grammar issues:
2026-11-15 22:50:56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #397.
CMake 4.5 expects every generated file that a target installs to be the
output of a custom command attached to exactly one target. Otherwise it
emits the author warning reported in #397 for the Makefile generators.
capnp_generate_cpp()lists bothproxy.capnp.c++andproxy.capnp.hasoutputs of one command, which ended up attached to both
mp_headersandmultiprocess. Addingadd_dependencies(multiprocess mp_headers), as thewarning suggests, does not help: the command is still attached to two targets.
This change runs the same
capnp compilecommand directly, withproxy.capnp.c++as a byproduct, so the command is attached only tomp_headers.multiprocessno longer lists the generated header as a source(it is still installed through
PUBLIC_HEADER) and depends onmp_headersso the generated source exists before it is compiled.
mp_headersstill onlygenerates headers and does not compile anything.
Tested with CMake 4.5.0: the warning is gone with Makefile and Ninja
generators.