Repository navigation
util: set FD_CLOEXEC atomically in SocketPair when SOCK_CLOEXEC is available #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ryanofsky
merged 1 commit into
bitcoin-core:master
from
javierpmateos:socketpair-cloexec
Nov 13, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In commit "util: set FD_CLOEXEC atomically in SocketPair when SOCK_CLOEXEC is available" (e8c449e)
Note: not asking for a change here, this looks fine. But it is a good example of a tradeoff this file keeps running into: either use
KJ_SYSCALLand leak descriptors when it throws, or add manualclose()calls and hand-written error reporting like this. The same choice comes up in other places in this file, and it gets a lot worse with the Windows code in #231, which has many more error paths.I think a better direction for followups would be to own descriptors with RAII from the moment they are created, so
KJ_SYSCALLcan throw freely without leaking, and only release them when ownership is handed off. KJ already provideskj::AutoCloseFdand, on Windows,kj::AutoCloseHandlefor this. Here it could look like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re: #394 (comment)
Yes, a follow-up would be welcome, thanks! Besides
SocketPair(),SpawnProcess()is a good place for it: if the secondSocketPair()call orconnect_info_to_args()throws, the first socket pair is never closed.