Skip to content

cmake: Fix silent include-what-you-use failures - #371

Merged
ryanofsky merged 2 commits into
bitcoin-core:masterfrom
ryanofsky:pr/iwyuerr
Oct 13, 2026
Merged

ryanofsky merged 2 commits into
bitcoin-core:masterfrom
ryanofsky:pr/iwyuerr

Conversation

@ryanofsky

Copy link
Copy Markdown
Collaborator

Problem: The IWYU check in the default CI job can fail with a bare Error 1 and no diagnostics (example). IWYU's clang frontend receives the GCC job's warning flags, so with -Werror -Wpedantic every KJ_TEST reports '__COUNTER__' is a C2y extension and the GCC-only -Wtrailing-whitespace is an unknown option. A file with 19 or more KJ_TESTs reaches clang's error limit, clang gives up before IWYU checks anything, and CMake discards IWYU's output because it contains no include suggestions. test/mp/test/test.cpp has 16 tests now. #335 adds three more and its default job fails this way, and master will hit it too once a few more tests are added.

Solution: Pass -w to IWYU so compiler warning flags no longer affect it, and run it through a small wrapper script that makes CMake print IWYU's output whenever it fails without suggesting includes. The wrapper works around a CMake bug (cmake#28020; an upstream fix in cmake!9210 was approved but never finished) and can be dropped once CMake fixes it.

Stop the compiler warning flags in CXXFLAGS from turning clang warnings
into errors in the IWYU pass. IWYU's clang frontend receives the same
flags as the real compiler, so in the GCC CI jobs (-Werror -Wpedantic)
every KJ_TEST reports "'__COUNTER__' is a C2y extension" and the
GCC-only -Wtrailing-whitespace is an unknown option. Once a file has
enough tests to reach clang's 20-error limit (test/mp/test/test.cpp
currently has 16), clang gives up, IWYU exits 1 without analyzing the
file, and the build fails with no diagnostics. Real IWYU findings are
still reported with -w.

This change was written with Claude Opus 5.5 (1M context).
Run include-what-you-use through a wrapper script that makes CMake print
its output when it fails without suggesting includes. CMake only relays
IWYU output containing "should add these lines:" or "should remove
these lines:", so a clang error in the IWYU pass (like the
too-many-errors abort fixed in the previous commit) failed the build
with a bare "Error 1" and nothing to debug.

This change was written with Claude Opus 5.5 (1M context).
@DrahtBot

DrahtBot commented Oct 2, 2026 •

Copy link
Copy Markdown

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers
ACK hebasto, xyzconstant

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

@hebasto hebasto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK.

@hebasto hebasto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f0a1475, I have reviewed the code and it looks OK.

@xyzconstant

Copy link
Copy Markdown
Contributor

LGTM ACK f0a1475

@ryanofsky
ryanofsky merged commit 686bccf into bitcoin-core:master Oct 13, 2026
14 checks passed
@ryanofsky

Copy link
Copy Markdown
Collaborator Author

Merged this to unblock #368

Sjors added a commit to stratum-mining/sv2-tp that referenced this pull request Oct 13, 2026
2e7812a5a1 Merge bitcoin-core/libmultiprocess#370: Fix Bitcoin Core build errors from libmultiprocess headers
686bccf766 Merge bitcoin-core/libmultiprocess#371: cmake: Fix silent include-what-you-use failures
f0a14754ef cmake: Show include-what-you-use diagnostics when it fails
92127a984a cmake: Pass -w to include-what-you-use
3577d23f61 ci: Enable -Wundef in default and llvm jobs
debd42955e proxy-types: Avoid -Wundef error when KJ_NO_EXCEPTIONS is not defined
a8c64c7faa ci: Enable -Wunused-const-variable in GCC jobs
701449c165 util: Make SocketError inline constexpr
REVERT: fcc569c2cf proxy-types: Avoid -Wundef error when KJ_NO_EXCEPTIONS is not defined
REVERT: fdeefd7aab util: Make SocketError inline constexpr

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: 2e7812a5a1ea8fada26f74b06be62e195a3783a5
@hebasto hebasto mentioned this pull request Oct 22, 2026
@Sjors Sjors mentioned this pull request Oct 28, 2026
fanquake added a commit that referenced this pull request Oct 28, 2026
1b742cf ci: Fix OpenBSD job (Hennadii Stepanov)

Pull request description:

  `vmactions/openbsd-vm` now [provides](https://github.com/vmactions/openbsd-vm/releases/tag/v1.4.9) OpenBSD 8.0 by default with Clang 22.1.6, which triggers `-Wc2y-extensions` on `__COUNTER__`.

  Disable the warning temporarily until the fix becomes available in Clang.

  See upstream LLVM items:
  - llvm/llvm-project#196557
  - llvm/llvm-project#196689
  - llvm/llvm-project#218669

  Related:
  - #371
  - https://github.com/bitcoin-core/libmultiprocess/actions/runs/39768415425/job/119789556263?pr=380

ACKs for top commit:
  maflcko:
    lgtm ACK 1b742cf
  xyzconstant:
    ACK 1b742cf
  ViniciusCestarii:
    ACK 1b742cf

Tree-SHA512: 673e5b61073ae1df8f577b6f12b31a33b7c9de1df64b5d57bb2bc61434d52ff3920be77cbcdb105bc72a610018ea9b5dc8eb1ad50a0a355842b38c7b3b0e95bf
fanquake pushed a commit to bitcoin/bitcoin that referenced this pull request Nov 5, 2026
acded1aafae Merge bitcoin-core/libmultiprocess#365: proxy-io: Generalize ConnectStream / ServeStream for use in tests
98f609ac50f Merge bitcoin-core/libmultiprocess#389: refactor: Enable modernize-use-scoped-lock
ee06487d861 refactor: Enable modernize-use-scoped-lock
263139f41dd Merge bitcoin-core/libmultiprocess#387: ci: use newer `actions/*` versions
388e37c5bc7 Merge bitcoin-core/libmultiprocess#386: gen: make `AccessorType` static
81e55578047 Merge bitcoin-core/libmultiprocess#383: ci: Compile capnproto with GCC in gnu32 job
c8ca0c0f6f1 ci: add -Wmissing-declarations to default.bash
3edd64840d0 Merge bitcoin-core/libmultiprocess#379: type: Accept any comparator, hash, and allocator in container fields
641c78ecacb ci: add -Wmissing-prototypes to LLVM config
52a028c8b78 gen: make AccessorType static
796dd742414 Merge bitcoin-core/libmultiprocess#380: .clang-tidy: Enable additional checks
b1816a8d02a Merge bitcoin-core/libmultiprocess#362: Enable `-Wunused`
cf2164ba0e2 ci: make curl fail more loudly
0bce5ed7a41 ci: use newer actions/ versions
ee8e64b87bc ci: add -Wunused to CI configs
fd75dc66964 refactor: use requires clauses instead of SFINAE enable parameters
0e6fffa8117 refactor: remove unused code
fabc4901269 .clang-tidy: Enable additional modernize checks
89bccd849ee Merge bitcoin-core/libmultiprocess#381: ci: Fix OpenBSD job
04a0465d67a ci: Compile capnproto with GCC in gnu32 job
1b742cfbbd7 ci: Fix OpenBSD job
a4fa10754c7 .clang-tidy: Enable additional checks not in upstream Bitcoin Core
7460e35896b .clang-tidy: Enable checks from upstream Bitcoin Core
9a42d0065d9 type: Accept any comparator, hash, and allocator in container fields
2e7812a5a1e Merge bitcoin-core/libmultiprocess#370: Fix Bitcoin Core build errors from libmultiprocess headers
686bccf766f Merge bitcoin-core/libmultiprocess#371: cmake: Fix silent include-what-you-use failures
f0a14754ef4 cmake: Show include-what-you-use diagnostics when it fails
92127a984a4 cmake: Pass -w to include-what-you-use
3577d23f616 ci: Enable -Wundef in default and llvm jobs
debd42955ea proxy-types: Avoid -Wundef error when KJ_NO_EXCEPTIONS is not defined
326ccfc2f87 test: simplify TestSetup using ServeStream/ConnectStream
6fd2a9c90e1 Merge bitcoin-core/libmultiprocess#367: mpgen: Change Cap'n Proto link order to fix undefined references in static builds
a8c64c7faa5 ci: Enable -Wunused-const-variable in GCC jobs
e46876545b4 proxy-io: add destroy_connection parameter to ServeStream and ConnectStream
701449c1657 util: Make SocketError inline constexpr
01808baa188 proxy-io: let ServeStream take ownership of init object
034e0d21b51 proxy-io: add EventLoop::incomingConnections()
f1042b1a60e Merge bitcoin-core/libmultiprocess#366: ci: Compile with minimum supported g++-10 in olddeps
a6ecdc113ff Merge bitcoin-core/libmultiprocess#364: util: Error out at compile time if KJ_NO_EXCEPTIONS is set
56cfdaa884e Change CapnProto library linkage for mpgen
fa5633467af ci: Compile with minimum supported g++-10 in olddeps
4a1f400f8b7 util: Error out at compile time if KJ_NO_EXCEPTIONS is set
2dba130478a Merge bitcoin-core/libmultiprocess#363: ci: use LLVM 23 in Bitcoin Core CI
161197a5c7b Merge bitcoin-core/libmultiprocess#352: ci: add cmake debug output
fb4ac7eb8c8 ci: use LLVM 23 in Bitcoin Core CI
7bac69de1fc Merge bitcoin-core/libmultiprocess#360: pull latest .clang-tidy from downstream
79ddc44eb32 Merge bitcoin-core/libmultiprocess#359: ci: bump cmake version to 4.3.4 in newdeps job
bf229bf82ae Merge bitcoin-core/libmultiprocess#351: ci: do not ignore NIXPKGS_CHANNEL in local ci runs
073ac4f1972 Merge bitcoin-core/libmultiprocess#347: refactor: Replace EventLoop::post() with sync() taking kj::FunctionParam
fa1db7a9e3e pull latest .clang-tidy from downstream
5c49666a1d8 refactor: rename EventLoop::m_post_fn to m_sync_fn
2330fbe81e2 refactor: replace EventLoop::post() with sync() taking kj::FunctionParam
4d454a8 Merge bitcoin-core/libmultiprocess#358: refactor: Enable readability-container-contains
dba9958 Merge bitcoin-core/libmultiprocess#357: doc: Update Cap'n Proto version to match minimum
0092392 Merge bitcoin-core/libmultiprocess#356: ci: Remove hard-coded -j4 from sanitize config
766867fb326 ci: clarify CAPNP_CHECKOUT=master is the v1.x release branch
cc3675280bf ci: bump cmake version to 4.3.4 in newdeps job
fa10111 refactor: Enable readability-container-contains
81f824b doc: Update Cap'n Proto version to match minimum
fa30e20 ci: Remove hard-coded -j4 from sanitize config
a7ff9d5da22 ci: add cmake debug output
f2e8df8 Merge bitcoin-core/libmultiprocess#350: cmake: add type-unordered-set.h and version.h to public headers
0e146c0 Merge bitcoin-core/libmultiprocess#349: type-context: fix async disconnect race condition found by antithesis
49f95e2 Merge bitcoin-core/libmultiprocess#212: ci: add newdeps job testing newer versions of cmake and capnproto
7c73cceda9b ci: rename CI-internal variables to use CI_ prefix
fe1b8339f00 ci: do not ignore NIXPKGS_CHANNEL in local ci runs
914dc83 proxy: fix data race between server request threads and disconnect handling
275c8ee Merge bitcoin-core/libmultiprocess#345: Remove trailing whitespace and Add -Wtrailing-whitespace to default ci config
cd7162f Merge bitcoin-core/libmultiprocess#304: proxy: fix BuildList to use non-const iteration for interface types
9b13678 ci: Add -Wtrailing-whitespace to default config
2f4be9e refactor: Remove trailing whitespace
2448d28 cmake: add type-unordered-set.h and version.h to public headers
b3fc922 ci: add newdeps job testing newest versions of cmake and capnproto
390b5f9 Merge bitcoin-core/libmultiprocess#344: test: listen_tests and connect_tests follow-ups
d6f8588 proxy: fix BuildList to use non-const iteration for interface types
e18ca52 Merge bitcoin-core/libmultiprocess#343: test: fix race in connect_tests disconnect-deferred-failure test
c39c785 doc: note construct() call in valid init interface test
b9c36c6 test: close sockets unconditionally and check errors with KJ_SYSCALL
7eb741e test: drop unnecessary KJ_EXPECT(true)
113f1d4 test: join server thread unconditionally in connect tests
44bc463 test: drop mp:: prefixes in connect tests
038d33e test: share DefaultLogHandler between test files
b54a163 test: drop TestSetup socket members in connect tests
70467c5 test: add m_ prefix to TestSetup members in connect tests
cc260f2 test: replace capnp fix link with upstream PR
137a6e4 test: fix race in connect_tests disconnect-deferred-failure test
8dab0d4 Merge bitcoin-core/libmultiprocess#341: ci: add -Wextra-semi to llvm config
b3b134e ci: add -Wextra-semi to llvm config
bdd0cd6 Merge bitcoin-core/libmultiprocess#339: refactor: add `[[noreturn]]` attributes
a779a09 ci: add -Wmissing-noreturn
636aaff refactor: add missing [[noreturn]] attributes
cc11c2b Merge bitcoin-core/libmultiprocess#338: test: check ReadList return value
2d6e863 Merge bitcoin-core/libmultiprocess#334: ci: Set CMAKE_BUILD_PARALLEL_LEVEL to enable parallelism by default
d4d10ff Merge bitcoin-core/libmultiprocess#332: ci: add -Wextra-semi to default config
b540e70 Merge bitcoin-core/libmultiprocess#324: proxy: Name threads spawned by the event loop
e5e367e Merge bitcoin-core/libmultiprocess#312: util: report back child errors to parent and throw
2220df6 Merge bitcoin-core/libmultiprocess#298: Fix error handling when creating clients (`mp::ConnectStream`)
51defb7 Merge bitcoin-core/libmultiprocess#340: ci: Update `capnproto` prerequisites on NetBSD
7e94790 ci: Update `capnproto` prerequisites on NetBSD
9f25ffc test: Cover OS thread names for worker, pool, and async threads
648a185 proxy: Name threads spawned by the event loop
49834b2 ci: add -Wextra-semi to default config
fae9a63 example: Remove unused kj/async.h include
bb47369 Fix error handling when creating clients
44d1914 Add test coverage for ConnectStream
231361a Correct stale UnixListener doc comment
060c1a5 Extract `UnixListener` class to a dedicated file
62f25af test: check ReadList return value
ce51d73 ci: Set CMAKE_BUILD_PARALLEL_LEVEL to enable parallism in build jobs by default
67302cd Merge bitcoin-core/libmultiprocess#331: Remove code for Cap'n Proto versions before 0.9
f13c64a Merge bitcoin-core/libmultiprocess#330: ci: Compile with minimum supported g++ in olddeps
8e026f6 Merge bitcoin-core/libmultiprocess#327: build: avoid unnecessary capnp-rpc dependency for mpgen
e5206e9 Merge bitcoin-core/libmultiprocess#325: cmake: Remove `QUIET` option from `find_package(CapnProto ...)`
879efea Merge bitcoin-core/libmultiprocess#321: ci: Roll NetBSD releases to 11.0, drop 9.4
abf127a Merge bitcoin-core/libmultiprocess#317: ipc: Fix mpgen capnp tool path for vcpkg/Windows builds
c437d7f Merge bitcoin-core/libmultiprocess#310: test: cover immediate client disconnects for `ListenConnections`
31bff8a Merge bitcoin-core/libmultiprocess#307: refactor: memcpy -> std::ranges::copy
f355108 Merge bitcoin-core/libmultiprocess#303: type-chrono: Add CustomBuildField/CustomReadField overloads for std::chrono::time_point
2d67817 Merge bitcoin-core/libmultiprocess#296: ci: Bump channel to nixos-26.05
3f05b11 util: kill and reap child on SpawnProcess error
4a56c18 util: report back child error to parent and throw
a9e70db ci: Add NetBSD release 11.0
2d33b14 ci: Switch to default compiler on NetBSD 9.4
36f7400 ci: Drop NetBSD release 9.4
bd50831 refactor: Drop stray semicolons after function definitions
788f17a Remove code for Cap'n Proto versions before 0.9
7402aff ci: Pin oldeps config to older nixpkgs channel to compile older cmake with older gcc
edf6343 ci: Compile with minimum supported g++-11 in olddeps
fa47449 cmake: avoid unnecessary capnp-rpc dependency for mpgen
a494b76 cmake: Remove `QUIET` option from `find_package(CapnProto ...)`
26452e0 refactor: memcpy -> std::ranges::copy
e1dcc6e Merge bitcoin-core/libmultiprocess#316: cmake: Fix stale codegen when mpgen binary changes
7a72df0 type-chrono: Add CustomBuildField/CustomReadField overloads for std::chrono::time_point
45b685c type-number, type-chrono: Fix static assert signed/unsigned comparisons
45f6255 type-number: exclude bool from the integral overload
8d6d464 Merge bitcoin-core/libmultiprocess#315: Fix startup race in example
a6fc80d Merge bitcoin-core/libmultiprocess#311: bugfix: clear FD_CLOEXEC in child instead of parent before fork
496fb84 test: cover immediate client disconnects for `ListenConnections`
36c6c63 doc: Document reference-counted EventLoop lifetime
3a997e1 Fix startup race in mpexample
f5c15ce Merge bitcoin-core/libmultiprocess#323: refactor: access ThreadContext through CurrentThread(), ci: switch Bitcoin Core to master
66298c7 ci: Switch back to Bitcoin Core's master branch
86b4810 refactor: access ThreadContext through CurrentThread()
eea9c64 cmake: Fix stale codegen when mpgen binary changes
a26a084 cmake: Fix mpgen capnp tool path for vcpkg/Windows builds
140d9ba test: allow custom log handler in `ListenSetup`
1e0c7ff util: Clear FD_CLOEXEC in child instead of parent before fork
8550ee6 util, refactor: Add ChildFail helper for post-fork child errors
17eab90 test: Fix typo in listen_tests.cpp
ce865a9 refactor: Directly use value in CustomBuildField
3f221b5 Merge bitcoin-core/libmultiprocess#274: Add nonunix platform support
1b0f605 doc: Remove trailing whitespace
d8f8ca3 ipc: Wrap mpgen main() in try-catch to print errors
fbe5a14 ci: Check out bitcoin/bitcoin PR #35084 instead of master
39d3690 types: Replace SFINAE with requires clauses to avoid MSVC C2039 error
ba68520 proxy, refactor: Fix C4305 truncation warning in Accessor on MSVC
1d81d47 util, refactor: Fix PtrOrValue constructor for move-only types on MSVC
b883fe1 proxy: Fix shutdownWrite() exception handling on macOS with dynamic libraries
0012411 proxy: Call shutdownWrite() in Connection destructor
38312ad proxy, refactor: Change ConnectStream and ServeStream to accept stream objects
e96d5d7 proxy, refactor: Replace EventLoop wakeup fd integers with KJ stream objects
db4f9a3 cmake: Bump minimum required Cap'n Proto version to 0.9
652934f util, refactor: Add SocketPair() and use it in SpawnProcess
1c6ef7a util, refactor: Do not fork() and exec() separately
1389cf3 util, refactor: Add SpawnConnectInfo type alias and use it
c7ca1f0 util, refactor: Add SocketId type alias and use it
be46a35 util, refactor: Add ProcessId type alias and use it
91a78db doc: Bump version 13 > 14
fa2c56e ci: Bump channel to nixos-26.05

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: acded1aafae12ce57d3d5a6ce3beb6870805f469
fanquake added a commit to bitcoin-core/gui that referenced this pull request Nov 5, 2026
…nunix platform support and fix race conditions

d5f7524 doc: Bump minimum required Cap'n Proto version to 0.9.2 (Ryan Ofsky)
4898199 build: suppress -Wc++23-lambda-attributes in warn_interface (Ryan Ofsky)
270f5db Squashed 'src/ipc/libmultiprocess/' changes from e8de5c7b68e..acded1aafae (Ryan Ofsky)

Pull request description:

  The changes can be verified by running `test/lint/git-subtree-check.sh src/ipc/libmultiprocess` as described in [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#subtrees) and [lint instructions](https://github.com/bitcoin/bitcoin/tree/master/test/lint#git-subtree-checksh).

  Changes since last subtree update (#35720):

  - Adds support for nonunix platforms, making API changes that are not backwards compatible ([#274](bitcoin-core/libmultiprocess#274)). Follow-ups add a `CurrentThread()` accessor matching compatibility code in [bitcoin/bitcoin#35084](bitcoin/bitcoin#35084) ([#323](bitcoin-core/libmultiprocess#323)) and remove code for Cap'n Proto versions before 0.9 ([#331](bitcoin-core/libmultiprocess#331)).
  - Fixes a data race between IPC calls running on worker threads and disconnects, found by Antithesis ([#349](bitcoin-core/libmultiprocess#349)).
  - Fixes a use-after-free when a socket disconnects before `ConnectStream` connects, and leaks and hangs when a client `construct()` call throws ([#298](bitcoin-core/libmultiprocess#298)).
  - Fixes a race where file descriptors from `SpawnProcess` could leak into processes forked at the same time by other threads, by clearing `FD_CLOEXEC` in the child after forking ([#311](bitcoin-core/libmultiprocess#311)).
  - Makes `SpawnProcess` report `exec` failures back to the parent and throw, reaping the child ([#312](bitcoin-core/libmultiprocess#312)).
  - Adds support for `std::chrono::time_point` fields ([#303](bitcoin-core/libmultiprocess#303)) and for serializing lists of interface objects that need to be moved from ([#304](bitcoin-core/libmultiprocess#304)), both needed by [bitcoin/bitcoin#10102](bitcoin/bitcoin#10102).
  - Accepts container fields and parameters with any comparator, hash, and allocator types, like Bitcoin Core's `GCSFilter::ElementSet`, needed by [bitcoin/bitcoin#29409](bitcoin/bitcoin#29409) ([#379](bitcoin-core/libmultiprocess#379)).
  - Finds the `capnp` tool in vcpkg and Windows builds, needed by [bitcoin/bitcoin#32387](bitcoin/bitcoin#32387) ([#317](bitcoin-core/libmultiprocess#317)).
  - Adds a `destroy_connection` option to `ServeStream` and `ConnectStream`, lets `ServeStream` take ownership of the init object and return the new server and its connection, and adds an `EventLoop::incomingConnections()` accessor, simplifying test setup in both repositories and needed by [bitcoin/bitcoin#35932](bitcoin/bitcoin#35932) ([#365](bitcoin-core/libmultiprocess#365)).
  - Replaces `EventLoop::post()` with `sync()` taking a `kj::FunctionParam`, avoiding a heap allocation per call ([#347](bitcoin-core/libmultiprocess#347)).
  - Names threads spawned by the event loop so they can be told apart in tools and logs ([#324](bitcoin-core/libmultiprocess#324)).
  - Fixes warnings that Bitcoin Core enables or plans to enable: adds `[[noreturn]]` attributes for `-Wmissing-noreturn` ([#339](bitcoin-core/libmultiprocess#339), for [bitcoin/bitcoin#35911](bitcoin/bitcoin#35911)), and fixes `-Wunused` ([#362](bitcoin-core/libmultiprocess#362), for [bitcoin/bitcoin#36167](bitcoin/bitcoin#36167)), `-Wunused-const-variable` and `-Wundef` ([#370](bitcoin-core/libmultiprocess#370)), and `-Wmissing-prototypes` ([#386](bitcoin-core/libmultiprocess#386), for [bitcoin/bitcoin#36743](bitcoin/bitcoin#36743)) warnings.
  - Fails at compile time with a suggested workaround when Cap'n Proto misdetects exception support (`KJ_NO_EXCEPTIONS`), as happens on NetBSD ([#364](bitcoin-core/libmultiprocess#364)).
  - Build improvements: fixes stale generated code when the `mpgen` binary changes ([#316](bitcoin-core/libmultiprocess#316)), fixes `mpgen` link order for static Cap'n Proto builds ([#367](bitcoin-core/libmultiprocess#367)), links `mpgen` against `kj-async` instead of `capnp-rpc` ([#327](bitcoin-core/libmultiprocess#327)), shows Cap'n Proto `find_package` diagnostics ([#325](bitcoin-core/libmultiprocess#325)), installs `type-unordered-set.h` and `version.h` ([#350](bitcoin-core/libmultiprocess#350)), and shows include-what-you-use errors instead of failing silently ([#371](bitcoin-core/libmultiprocess#371)).
  - Test, CI, documentation, and minor code improvements: fix for a startup race in the example program ([#315](bitcoin-core/libmultiprocess#315)), new test for immediate client disconnects in `ListenConnections` ([#310](bitcoin-core/libmultiprocess#310)), `ReadList` return value check ([#338](bitcoin-core/libmultiprocess#338)), connect test race fix ([#343](bitcoin-core/libmultiprocess#343)) and cleanups ([#344](bitcoin-core/libmultiprocess#344)), `std::ranges::copy` follow-ups ([#307](bitcoin-core/libmultiprocess#307)), trailing whitespace removal ([#345](bitcoin-core/libmultiprocess#345)), Cap'n Proto version documentation fix ([#357](bitcoin-core/libmultiprocess#357)), clang-tidy updates ([#358](bitcoin-core/libmultiprocess#358), [#360](bitcoin-core/libmultiprocess#360), [#380](bitcoin-core/libmultiprocess#380), [#389](bitcoin-core/libmultiprocess#389)), new CI job testing newer cmake and Cap'n Proto versions ([#212](bitcoin-core/libmultiprocess#212), [#359](bitcoin-core/libmultiprocess#359)), CI coverage for the minimum supported g++ ([#330](bitcoin-core/libmultiprocess#330), [#366](bitcoin-core/libmultiprocess#366)), new CI warnings ([#332](bitcoin-core/libmultiprocess#332), [#341](bitcoin-core/libmultiprocess#341)), CI parallelism ([#334](bitcoin-core/libmultiprocess#334), [#356](bitcoin-core/libmultiprocess#356)), CI diagnostics ([#351](bitcoin-core/libmultiprocess#351), [#352](bitcoin-core/libmultiprocess#352)), Nix and LLVM updates ([#296](bitcoin-core/libmultiprocess#296), [#363](bitcoin-core/libmultiprocess#363)), NetBSD and OpenBSD CI fixes ([#321](bitcoin-core/libmultiprocess#321), [#340](bitcoin-core/libmultiprocess#340), [#381](bitcoin-core/libmultiprocess#381)), building Cap'n Proto with GCC in the 32-bit CI job to avoid an ABI mismatch ([#383](bitcoin-core/libmultiprocess#383)), and GitHub Actions updates ([#387](bitcoin-core/libmultiprocess#387)).

  The second commit suppresses the clang `-Wc++23-lambda-attributes` warning, which the new `[[noreturn]]` lambda attribute in `mp/proxy-types.h` triggers in C++20 builds. Since #31507 the Windows build uses clang-cl, so the same flag covers it.

  The third commit updates the minimum Cap'n Proto version in `doc/dependencies.md` to 0.9.2 (1.0 with Clang). This update raises libmultiprocess's own minimum from 0.7 to 0.9 (bitcoin-core/libmultiprocess#331), and libmultiprocess rejects 0.9.0 and 0.9.1 for CVE-2022-46149 and, with Clang 16 or newer, every version before 1.0.

ACKs for top commit:
  fanquake:
    ACK d5f7524
  willcl-ark:
    ACK d5f7524

Tree-SHA512: 4064944f4d8bb6c1665ddc7d5fae838492235d7dfdafab88b19b687ff6892460a3f450b90a145b287866330c569b862d748c941a70c65abc7f273ef13e490fd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants