Repository navigation
ledger: Fix derivation path indexing in multisig address display - #856
Open
PraneethGunas wants to merge 1 commit into
Open
PraneethGunas wants to merge 1 commit into
PraneethGunas wants to merge 1 commit into
Conversation
deriv_path is a list of lists, but the length check and indices kept the offsets of the old string representation. This fixes it.
nogibi
added a commit
to nogibi/HWI
that referenced
this pull request
Oct 9, 2026
agammann
reviewed
Nov 11, 2026
agammann
left a comment
There was a problem hiding this comment.
This fixes two incorrect derivation-path offsets in the Ledger multisig address display path, but the PR has no regression test for the branch/index passed to get_wallet_address. Could a mocked Ledger client exercise a concrete descriptor such as /1/7 and assert the call receives change=1, address_index=7, plus a malformed or ranged suffix is rejected? That would protect the exact indexing behavior this patch repairs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deriv_path is a list of lists, but the length check and indices kept the offsets of the old string representation. This fixes it.