Skip to content

ledger: Fix derivation path indexing in multisig address display - #856

Open
PraneethGunas wants to merge 1 commit into
bitcoin-core:masterfrom
PraneethGunas:fix-ledger-multisig-deriv-path
Open

PraneethGunas wants to merge 1 commit into
bitcoin-core:masterfrom
PraneethGunas:fix-ledger-multisig-deriv-path

Conversation

@PraneethGunas

Copy link
Copy Markdown

deriv_path is a list of lists, but the length check and indices kept the offsets of the old string representation. This fixes it.

deriv_path is a list of lists, but the length check and indices kept the
offsets of the old string representation. This fixes it.
nogibi added a commit to nogibi/HWI that referenced this pull request Oct 9, 2026

@agammann agammann left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes two incorrect derivation-path offsets in the Ledger multisig address display path, but the PR has no regression test for the branch/index passed to get_wallet_address. Could a mocked Ledger client exercise a concrete descriptor such as /1/7 and assert the call receives change=1, address_index=7, plus a malformed or ranged suffix is rejected? That would protect the exact indexing behavior this patch repairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants