Repository navigation
Conversation
bebdbc2 to
d56cf15
Compare
# Conflicts: # hwilib/descriptor.py # test/test_descriptor.py # test/test_device.py
# Conflicts: # hwilib/descriptor.py # test/test_descriptor.py # test/test_device.py
|
I'm adding Jade device support for |
d56cf15 to
a1ba686
Compare
a1ba686 to
ff359ee
Compare
# Conflicts: # hwilib/descriptor.py # test/test_bitbox02.py # test/test_coldcard.py # test/test_descriptor.py # test/test_device.py
ff359ee to
35588fe
Compare
|
Rebased after #792. |
|
Comment, not an ACK: the descriptor in The |
Introduce get_derivation_providers() and route the existing key collection and derive() through it, preserving repeated keys and traversal order.
Cover repeated key expressions with different suffixes and assign one BIP 388 key-information entry and placeholder index to each key. Keep derivation traversal separate so every occurrence is still derived.
Registered descriptor policies may contain Miniscript expressions in P2WSH. Parse their structure so keys land in the BIP 388 key information vector and the same policy validation applies as for other descriptors. Miniscript type checking remains the responsibility of the device.
35588fe to
73966d9
Compare
|
@fametrano good catch, taken. I split a few independent fixes out into #862. I also reduced the scope of this PR to just Miniscript support, and opened #863 as a followup for MuSig2. |
Split from #794 for easier review.