Skip to content

ColdCard: test_signtx broken #799

Closed

Description

@Sjors

test_signtx has been temporarily disabled by #795. It failed with:

ERROR: coldcard: test_signtx (test_device.TestSignTx.test_signtx) (addrtypes=['legacy'], multisig_types=['legacy'], external=True, op_return=False)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/HWI/HWI/test/test_device.py", line 588, in test_signtx
    self._test_signtx(addrtypes, multisig_types, external, op_return)
  File "/__w/HWI/HWI/test/test_device.py", line 576, in _test_signtx
    self._generate_and_finalize(True, psbt)
  File "/__w/HWI/HWI/test/test_device.py", line 403, in _generate_and_finalize
    self.assertTrue(first_sign_res["signed"])
                    ~~~~~~~~~~~~~~^^^^^^^^^^
KeyError: 'signed'

Activity

  1. changed the title [-]ColdCard: signtx test broken[/-] [+]ColdCard: test_signtx broken[/+] on Jul 24, 2025
  2. Sjors commented on Jul 24, 2025

    @Sjors
    MemberAuthor
  3. brunoerg commented on Jul 24, 2025

    @brunoerg
    Contributor

    I'm taking a look at it.

  4. brunoerg commented on Jul 29, 2025

    @brunoerg
    Contributor

    As far as I could debug, it seems an issue on the multisig wallet: {'error': 'Coldcard Error: Unknown multisig wallet', 'code': -7}

  5. brunoerg commented on Jul 29, 2025

    @brunoerg
    Contributor

    test_big_tx is broken here as well.

    ======================================================================
    FAIL: coldcard: test_big_tx (test_device.TestSignTx)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Users/brunogarcia/projects/HWI/test/test_device.py", line 610, in test_big_tx
        self.fail('Big tx did not cause CLI to error')
    AssertionError: Big tx did not cause CLI to error
    
  6. Sjors commented on Jul 29, 2025

    @Sjors
    MemberAuthor

    test_big_tx is broken here as well.

    Indeed I disabled them both in #795

  7. added a commit that references this issue on Sep 3, 2025
  8. Sjors commented on Aug 18, 2026

    @Sjors
    MemberAuthor

    test_big_tx is fine

  9. Sjors commented on Aug 18, 2026

    @Sjors
    MemberAuthor

    #849 brings back test_signtx for single sig, while #792 can bring it back for multisig (if rebased on 792)

  10. added a commit that references this issue on Aug 20, 2026
    8593a75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions