Repository navigation
[FIX] File, Load Model, Distance File: do not leak recent files into a saved workflow - #7228
Conversation
markotoplak
changed the title
fea41a1 to
57e7916
Compare
janezd
changed the title
janezd
changed the title
|
orange-widget-base with biolab/orange-widget-base/pull/291 is now released |
f291481 to
a78d387
Compare
a78d387 to
d9e8810
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (84.44%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #7228 +/- ##
==========================================
- Coverage 88.99% 88.98% -0.01%
==========================================
Files 337 337
Lines 74598 74633 +35
==========================================
+ Hits 66387 66412 +25
- Misses 8211 8221 +10 🚀 New features to boost your workflow:
|
| # GUI requirements | ||
| oldest: orange-canvas-core==0.2.9 | ||
| oldest: orange-widget-base==4.25.0 | ||
| oldest: orange-widget-base==4.28.0 |
There was a problem hiding this comment.
requirements-gui.txt and conda-recipe/meta.yaml should also be updated
| self.open_file() | ||
|
|
||
| @classmethod | ||
| def migrate_settings(cls, settings, version): |
There was a problem hiding this comment.
This could be implemented on the mixin.
There was a problem hiding this comment.
I realized this, too, but it was too late: the mixin is in orange-widget-base, which was just released. I opened a PR there and made sure we'll change this in the future (biolab/orange-widget-base#299).
VesnaT
left a comment
VesnaT
left a comment
There was a problem hiding this comment.
Drop handlers still return recent_paths. This only works because the settings pass through migration.
47d9957 to
eba6037
Compare
... which incidentally did exactly the right thing. :) I implemented a more explicit route, though. :) |
eba6037 to
d3beb46
Compare
d3beb46 to
8e60180
Compare
Issue
Resolves #4919. Requires biolab/orange-widget-base#291 to be merged and released.
Also fixes a bug in Load Model and Distance File: Combo box was not updated after loading a file by calling
self.set_file_list()after (successfully) opening a file.Description of changes
We decided against using schema-only settings because you would lose your own, personal history of recent files. Plus, you could still leave unwanted files in the workflow.
Includes