Skip to content

fix: update labeler configuration#16

Open
0xBingo wants to merge 2 commits into
masterfrom
fix/update-labeler-rules
Open

fix: update labeler configuration#16
0xBingo wants to merge 2 commits into
masterfrom
fix/update-labeler-rules

Conversation

@0xBingo

@0xBingo 0xBingo commented Mar 6, 2025

Copy link
Copy Markdown
Collaborator

📋 Description

Briefly describe the purpose of this PR: Update missing labeler rules and fix


⚠️ Points of Attention

Are there any specific aspects that need extra attention?

  • Potential impacts on other features or services: N/A
  • Breaking changes or migrations required: N/A
  • Dependencies or external services involved: N/A

🧪 How to Test

Procedure to test this PR:

  1. Clone the branch and navigate to the project folder.
  2. Check if the pipeline works as expected.

🚀 Deployment

Procedure to deploy this PR to production:

  1. Merge this PR into the master branch.
  2. Ensure the CI/CD pipeline completes successfully.

🔗 Related Issues

  • Closes issue : N/A
  • Related to issue : N/A

🙏 Additional Notes

  • Anything else the reviewers should know: N/A
  • Screenshots or GIFs to demonstrate the change: N/A

@0xBingo 0xBingo self-assigned this Mar 6, 2025
@0xBingo 0xBingo force-pushed the fix/update-labeler-rules branch 4 times, most recently from 35d3374 to cba0748 Compare March 7, 2025 15:02
@0xBingo 0xBingo force-pushed the fix/update-labeler-rules branch from cba0748 to 9da4f0d Compare March 7, 2025 15:23
@0xBingo 0xBingo requested a review from Copilot June 1, 2025 02:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Update labeler configuration to use head-branch regex and file glob patterns, and add a kubernetes label.

  • Replace branch prefix patterns under branches with head-branch regex lists for existing labels.
  • Migrate changed-files rules to new any-glob-to-any-file keys (ansible, terraform) and add a new kubernetes label.
Comments suppressed due to low confidence (5)

.github/labeler.yml:28

  • The key any-glob-to-any-file does not match the labeler schema; it should use changed-files (or paths) to ensure the rule is recognized.
any-glob-to-any-file:

.github/labeler.yml:29

  • This pattern only matches YAML files under ansible/; the original rules also covered all file types in ansible/** and root-level *.yml – consider restoring those to maintain coverage.
- 'ansible/**/*.yml'

.github/labeler.yml:34

  • The key any-glob-to-any-file here will not be picked up by the labeler; please revert to changed-files (or paths) to apply the rule.
any-glob-to-any-file:

.github/labeler.yml:35

  • This glob only matches .tf files under terraform/; the previous config also covered any .tf anywhere in the repo – consider adding **/*.tf and **/*.tfvars to preserve full coverage.
- 'terraform/**/*.tf'

.github/labeler.yml:36

  • Similar to the comment above, this matches only .tfvars under terraform/; include a broader **/*.tfvars pattern if you intend to catch files outside that directory.
- 'terraform/**/*.tfvars'

Comment thread .github/labeler.yml
- 'terraform/**/*.tf'
- 'terraform/**/*.tfvars'

kubernetes:

Copilot AI Jun 1, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] You’ve added a kubernetes label based solely on file changes; consider also adding a head-branch rule to mirror the branch-based labeling in other sections for consistency.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants