fix: update labeler configuration#16
Open
0xBingo wants to merge 2 commits into
Open
Conversation
ci: add pr labeler
35d3374 to
cba0748
Compare
cba0748 to
9da4f0d
Compare
There was a problem hiding this comment.
Pull Request Overview
Update labeler configuration to use head-branch regex and file glob patterns, and add a kubernetes label.
- Replace branch prefix patterns under
brancheswithhead-branchregex lists for existing labels. - Migrate
changed-filesrules to newany-glob-to-any-filekeys (ansible, terraform) and add a new kubernetes label.
Comments suppressed due to low confidence (5)
.github/labeler.yml:28
- The key
any-glob-to-any-filedoes not match the labeler schema; it should usechanged-files(orpaths) to ensure the rule is recognized.
any-glob-to-any-file:
.github/labeler.yml:29
- This pattern only matches YAML files under
ansible/; the original rules also covered all file types inansible/**and root-level*.yml– consider restoring those to maintain coverage.
- 'ansible/**/*.yml'
.github/labeler.yml:34
- The key
any-glob-to-any-filehere will not be picked up by the labeler; please revert tochanged-files(orpaths) to apply the rule.
any-glob-to-any-file:
.github/labeler.yml:35
- This glob only matches
.tffiles underterraform/; the previous config also covered any.tfanywhere in the repo – consider adding**/*.tfand**/*.tfvarsto preserve full coverage.
- 'terraform/**/*.tf'
.github/labeler.yml:36
- Similar to the comment above, this matches only
.tfvarsunderterraform/; include a broader**/*.tfvarspattern if you intend to catch files outside that directory.
- 'terraform/**/*.tfvars'
| - 'terraform/**/*.tf' | ||
| - 'terraform/**/*.tfvars' | ||
|
|
||
| kubernetes: |
There was a problem hiding this comment.
[nitpick] You’ve added a kubernetes label based solely on file changes; consider also adding a head-branch rule to mirror the branch-based labeling in other sections for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
Briefly describe the purpose of this PR: Update missing labeler rules and fix
Are there any specific aspects that need extra attention?
🧪 How to Test
Procedure to test this PR:
🚀 Deployment
Procedure to deploy this PR to production:
masterbranch.🔗 Related Issues
🙏 Additional Notes