Skip to content

Add max file size limit 10MB for photo uploads - #539

Open
neal-bpm wants to merge 1 commit into
mainfrom
fix/photo-upload-size-label
Open

neal-bpm wants to merge 1 commit into
mainfrom
fix/photo-upload-size-label

Conversation

@neal-bpm

@neal-bpm neal-bpm commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes

Adds an explicit 10 MB file size limit to photo uploads in the Program form. Previously allow_upload had no max_file_size set, meaning Phoenix's default of 8 MB applied silently. This makes the limit explicit and raises it to 10 MB, aligning with user expectations for photo uploads.

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added tests.
  • Are there other PRs or Issues that I should link to here?
  • Will this be part of a product update? If yes, please write one phrase
    about this update in the description above.

Summary by CodeRabbit

  • Bug Fixes
    • Photo uploads now enforce a 10 MB maximum file size. Accepted file types and the 10-upload limit are unchanged.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: bikebrigade/dispatch/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 747f7de2-3c2f-4ecd-b8aa-460fe8ff8e69

📥 Commits

Reviewing files that changed from the base of the PR and between 6930d01 and 0d78529.


📒 Files selected for processing (1)
  • lib/bike_brigade_web/live/program_live/form_component.ex

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

Photo uploads now have a maximum file size of 10,000,000 bytes. The accepted extensions and 10-upload limit remain unchanged.

Changes

Photo uploads

Layer / File(s) Summary
Set photo upload limit
lib/bike_brigade_web/live/program_live/form_component.ex
mount/1 sets a maximum size of 10,000,000 bytes per photo upload. Accepted extensions and the 10-upload limit remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature


Merge Risk: ⚪ Minimal · up to 0d785

Oversized photo uploads are rejected before storage, and no material merge-blocking issue is evident.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely describes the main change: adding a 10 MB maximum file size for photo uploads.
Description check Passed The description explains the change, provides relevant context, and includes the required checklist. Optional ticket, test, issue, and product-update details are either not applicable or clearly marke…


  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@neal-bpm neal-bpm self-assigned this Oct 9, 2026
@neal-bpm
neal-bpm requested a review from mveytsman October 9, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants