BUG1925390 Fix IPv6 session cookie matching - #455
Open
yunusarista wants to merge 1 commit into
Open
Conversation
Login scoped the session cookie to urlparse(url).hostname. For IPv6 literal URLs, urlparse strips the brackets from the hostname, while requests matches cookies against the bracketed request authority. The mismatch caused the login cookie to be stored but not sent on later API requests, resulting in 401 responses after a successful login. Create the login cookie without an explicit domain so the dedicated requests.Session can send it for both IPv4 and IPv6 hosts. Add a regression test that prepares requests for IPv4 and bracketed IPv6 URLs and verifies the session cookie is attached. Fixes: BUG1925390
yunusarista
marked this pull request as ready for review
August 5, 2026 13:36
yunusarista
requested review from
Kinjal-Arista,
andi-bigswitch and
pazur-arista
August 5, 2026 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login scoped the session cookie to urlparse(url).hostname. For IPv6 literal URLs, urlparse strips the brackets from the hostname, while requests matches cookies against the bracketed request authority. The mismatch caused the login cookie to be stored but not sent on later API requests, resulting in 401 responses after a successful login.
Create the login cookie without an explicit domain so the dedicated requests.Session can send it for both IPv4 and IPv6 hosts. Add a regression test that prepares requests for IPv4 and bracketed IPv6 URLs and verifies the session cookie is attached.
Fixes: BUG1925390