feat: make bigPage/sidebar/bigTabs/settings/sidebarHelp nestable via id - #27
Merged
Conversation
…ble via optional id parameter - Add BIGDASH_DEFAULT_ID constant and scoped_id() utility in R/utils.R - Update bigPage(), sidebar(), bigTabs(), settings(), sidebarHelp() to accept and use id (with scoped_id for nesting support) - Update JS in srcjs/scope.js, sidebar.js, settings.js to handle scoped/nested IDs for tabs, settings panel, and help - Rebuild assets (JS bundle, CSS, docs) - This enables nesting bigdash components (e.g. bigPage inside another dashboard) without ID conflicts Closes nestable-bigpage-id feature request.
ESCRI11
approved these changes
Aug 11, 2026
ESCRI11
left a comment
ESCRI11
left a comment
Contributor
There was a problem hiding this comment.
claude review + manual test on opg. all looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the main bigdash layout components nestable by supporting an optional
idparameter (defaults to a stable BIGDASH_DEFAULT_ID).Changes
scoped_id()inR/utils.Rfor generating nested/scoped IDs (prevents conflicts when embedding one bigPage inside another).bigPage(),sidebar(),bigTabs(),settings(),sidebarHelp()and related functions to accept and propagateid.srcjs/scope.js,sidebar.js,settings.jsto handle scoped selectors and events properly.inst/assets/index.js,inst/assets/style.min.css, documentation, and NAMESPACE.This addresses the nestable-bigpage-id feature request.
cc @xavier
Ready for review.