Skip to content

[upstream #16604] Move ChatView's saveDrafts read to ChatSettings after #15911 #224

Description

@berry-13

LibreChat-AI#16604 moves saveDrafts behind the host ChatSettings context for every chat reader except ChatView, which still reads store.saveDrafts and passes it to AskAnswerHostProvider (ChatView.tsx:61, :177). ChatView.tsx is owned by the open LibreChat-AI#15911, so it was left on the store.

Finding: LibreChat-AI#16604 (comment)

Once LibreChat-AI#15911 merges, have ChatView take saveDrafts from useChatSettings() (or let AskAnswerHostProvider read it from the context and drop the prop), so a host that supplies its own value drives ask-answer draft saving too. Inside the app the two sources hold the same value, so there is no user-visible divergence today.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: clientreviewctl followups statereadyreviewctl followups staterefactorreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions