feat!: upgrade llama.cpp from b10817 to b10819 - #417
Merged
Conversation
No project-source change, and this time the review surface is empty rather than
merely small: the range is 2 commits over 3 files, all of them ggml backends or
upstream tests, none of which this project links against or compiles into
jllama. Nothing under common/, include/, tools/server/, tools/mtmd/ or
ggml/include/ moved at all. The server contract was re-checked anyway and is
byte-identical (request-field set, response keys in both emit forms).
* #28399 metal : one-line memory-leak fix on an early-return path
* #28254 sycl : restore Kronecker-product FWHT support, unbreak
test-backend-ops on SYCL
The Metal leak fix deserves a note next to the macOS-15 regression tracked from
b10797, because it is adjacent to the symptom without being the cause: that job
logs "current allocated size is greater than the recommended max working set
size", so a leaked Metal object on an early return is the right neighbourhood.
It is NOT a fix. The observed failure is a libc++ "vector" exception thrown
~30 ms into llama_model_load of the draft model, before allocation of that kind,
and the no-Metal macOS job fails identically. One variable removed, not the
answer -- expect `Java Tests macOS 15 arm64` to stay red until that is bisected.
Patches: zero intersection with the 42 files the eight patches touch, so no
context can have moved. The applier was run for real regardless -- fresh build
dir, configure clean, stamp at head 6a1a922d, all eight hashes recorded.
No chunking question arises: the full diff is 17 KB across 2 commits, far inside
the runbook's 100 KiB threshold, so this is a straight bump BY the rule rather
than an exception to it.
Verified locally: fresh configure clean, full build with zero warnings on the
project TUs, ctest 520/520, mvn clean verify 1742 Java tests green (including
NativeLibraryLoadSmokeTest, which cross-checks LLAMA_CPP_VERSION against the
linked build-info), bytecode gate clean over llama/target.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AnNYn8W1xuVxVJtyL34GyH
bernardladenthin
had a problem deploying
to
startgate
September 5, 2026 18:23 — with
GitHub Actions
Error
bernardladenthin
had a problem deploying
to
maven-central
September 5, 2026 18:23 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
September 5, 2026 18:23 — with
GitHub Actions
Failure
|
✅ Code Review: Version Bump b10817 → b10819 SummaryThis is a well-executed, mechanical version bump following the documented runbook precisely. VerificationPin Files Complete — All four required locations updated:
Documentation — No stale references:
Upstream Changes Assessment — Review surface correctly identified as empty:
None linked by the project's JNI layer. Quality Gates — All passing:
Note on macOS-15 regression: Correctly identified as pre-existing (b10797) and not addressed by the Metal leak fix, which is adjacent to the symptom but not the root cause. ✅ Approved — ready to merge. |
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
llama/CMakeLists.txtGIT_TAG,README.mdbadge + link,CLAUDE.md,LlamaCppVersion.java), plus aCHANGELOG.mdentry and two rows indocs/history/llama-cpp-breaking-changes.md.jllama. Nothing undercommon/,include/,tools/server/,tools/mtmd/,ggml/include/or the top-levelCMakeLists.txtmoved at all.#28399metal: one-line memory-leak fix on an early-return path (ggml/src/ggml-metal/ggml-metal-context.m)#28254sycl: restore Kronecker-product FWHT, unbreaktest-backend-opson SYCL (ggml/src/ggml-sycl/fwht.cpp,tests/test-backend-ops.cpp)set_hard_limitsbounds, response keys in both emit forms) — byte-identical.6a1a922d269908a29cbd4b49c27e6a8e7fd10faewith all eight patch hashes recorded.Note on the Metal leak fix vs. the macOS-15 regression
#28399is adjacent to the macOS-15 symptom without being its cause, and it is worth saying so explicitly so nobody reads this PR as the fix. That job logs "current allocated size is greater than the recommended max working set size", so a leaked Metal object on an early-return path is the right neighbourhood. But the observed failure is a libc++"vector"exception thrown ~30 ms intollama_model_loadof the draft model — before allocation of that kind — and the no-Metal macOS job fails identically. One variable removed, not the answer.Test plan
ctest --test-dir build→ 520/520mvn clean verify→ 1742 tests, 0 failures, 0 errors (incl.NativeLibraryLoadSmokeTest, which cross-checksLLAMA_CPP_VERSIONagainst the linked build-info — this is the guard that catches a half-applied pin).github/verify-bytecode-version.sh --max-major 52 llama/target→ scanned 616 class files in 5 jars; 0 jars over major 52Java Tests macOS 15 arm64is expected to stay red, for the pre-existing b10797 regression described above, not for anything in this range. Every other job should be green.Related issues / PRs
Follows #415 (b10797 → b10817). Upstream range: ggml-org/llama.cpp@b10817...b10819
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.md🤖 Generated with Claude Code
https://claude.ai/code/session_01AnNYn8W1xuVxVJtyL34GyH
Generated by Claude Code