forked from kherud/java-llama.cpp
-
Notifications
You must be signed in to change notification settings - Fork 4
feat!: llama.cpp b10731, value-taking flash-attn, and the --lazy-mode rename #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
llama/src/main/java/net/ladenthin/llama/args/FlashAttn.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // SPDX-FileCopyrightText: 2026 Bernard Ladenthin <bernard.ladenthin@gmail.com> | ||
| // SPDX-FileCopyrightText: 2023-2025 Konstantin Herud | ||
| // | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| package net.ladenthin.llama.args; | ||
|
|
||
| /** | ||
| * Flash Attention mode for {@code --flash-attn}. | ||
| * | ||
| * <p>llama.cpp turned {@code --flash-attn} from a bare flag into a value-taking option in b10273: | ||
| * the value is mandatory, and emitting the key alone makes the parser consume whatever argv token | ||
| * follows it. That is why this is an enum rather than a boolean — see | ||
| * {@link net.ladenthin.llama.parameters.ModelParameters#setFlashAttn(FlashAttn)}.</p> | ||
| */ | ||
| public enum FlashAttn implements CliArg { | ||
|
|
||
| /** Force Flash Attention on; the model load fails if the backend cannot provide it. */ | ||
| ON("on"), | ||
| /** Force Flash Attention off. */ | ||
| OFF("off"), | ||
| /** Let llama.cpp decide per backend and model — upstream's own default. */ | ||
| AUTO("auto"); | ||
|
|
||
| private final String argValue; | ||
|
|
||
| FlashAttn(String argValue) { | ||
| this.argValue = argValue; | ||
| } | ||
|
|
||
| @Override | ||
| public String getArgValue() { | ||
| return argValue; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documentation states "the Java names (
setTensorReadLazy,TensorReadLazyMode) were deliberately left alone" but the PR actually renames both of these:TensorReadLazyMode→LazyMode(file rename + class rename)setTensorReadLazy()→setLazyMode()The CHANGELOG.md correctly documents these as breaking changes (line 37). This history entry should be updated to match, or clarified if the statement refers to a different decision point.