Skip to content

Preserve native video layout positioning and add DPI/zoom regressions - #4

Draft
benedictusrey wants to merge 1 commit into
mainfrom
fix/issue-3-preserve-native-layout
Draft

benedictusrey wants to merge 1 commit into
mainfrom
fix/issue-3-preserve-native-layout

Conversation

@benedictusrey

Copy link
Copy Markdown
Owner

Summary

Related to #3. This fixes a reproduced media-helper layout defect, but the reporter's exact live-account clipping has not yet been reproduced. Please keep #3 open pending that confirmation.

The v2.2.0 stylesheet forces every video parent to position: relative !important. In a controlled real-browser fixture, installing the helper changes absolute/fixed/sticky hosts and shifts surrounding profile-sidebar geometry. The old implementation fails the new regression.

The focused repair preserves already positioned hosts. Only static parents receive a zero-specificity, non-important anchor fallback; later Instagram layout rules remain authoritative. No default window resolution, sidebar offset, DM CSS, audio settings or interaction handlers change.

Verification

  • 18 Edge layout cases passed across viewport, device-scale and body-zoom combinations.
  • 7 JavaScript and 13 Rust tests passed.
  • Existing Edge media suite: 30 checks passed (seek/drag, compact cards, playback, mute/volume, navigation and event isolation).
  • Additional inbox polling/backoff/disposal and DM scrolling checks passed.
  • Syntax, formatting and whitespace checks passed; an automated Chromium layout workflow is included.

See docs/issue-3-layout-verification.md for reproduction and evidence boundaries.

Report-specific confirmation still needed

The maintainer's screenshot is normal at 1920x1080 / 100% Windows scaling. The reporter's app version, viewport, zoom, scroll position and reproduction steps are unknown. DPR emulation does not prove physical Windows DPI-transition behavior. This PR stays draft until the repair can be checked against the reported layout; it does not claim that 2K/4K resolution itself caused the issue.

Contributor attribution and existing copyright notices are preserved. No published release is replaced by this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant