Repository navigation
Conversation
Collaborator
|
Thanks for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1513.
ty_holdsused a datatype-name set as a global visited set. After openingBox<Num{}>, it skipped the fields of the siblingBox<Fun{}>and missed the host-minted closure. Track active datatype expansions instead: remove the name after scanning its constructor fields. Recursive-name cycle protection remains, but sibling value-indexed instances are inspected independently. No type-key serialization, copied visited sets, checker changes, runtime workaround, or special-case Box/Tag handling.Adds the original two-Box closure-bang program as a permanent regression for the existing GPU-enabled test gate. The helper's source documentation explains the active-path invariant. Protected
bend2/bend.ts, hand-writtenguide/GUIDE.md, release-only CHANGELOG.md and gates/caps are unchanged.Real behavior proof
Linux x86_64, Bun CLI 1.3.13, Node v22.23.1, clang 22.1.8. Based on current main
381dc877.--gpu off --threads 4) run the reported program and print 42. CPU execution is a control: it already succeeds on main and does not reproduce the original Metal failure.clang -E -P -x c -D__CUDACC_RTC__=1 program.c, without emulating a GPU or changing its guards. The host-minted closure is FID 4 in these artifacts. Before: the device evaluator has no case 4 and retains the missing-function error default. After: case 4 is included in the real device dispatch. This proves the changed compiler path, not a GPU runtime pass.bun gates/repo.ts: 54/54.An earlier real JS BigInt-seam reproduction was removed from this patch after upstream #1506 changed Nat host values to numbers and removed the old converter. It is not repinned to an incidental new default.
Validation limits
Metal/CUDA hardware and the 48-mini distributed gate were unavailable. The permanent original regression must run on the existing upstream GPU-enabled gate; no actual device success or performance is claimed here. The preprocessing comparison is a throwaway artifact check, not a permanent source-text test.