Skip to content

Reject zero per-repo concurrency #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
behinddwalls wants to merge 1 commit into from
Closed

Reject zero per-repo concurrency #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions crates/walgit-config/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,6 +1081,10 @@ impl Config {
self.server.max_concurrent_requests > 0,
"server.max_concurrent_requests must be positive"
);
anyhow::ensure!(
self.server.max_concurrent_per_repo > 0,
"server.max_concurrent_per_repo must be positive"
);
anyhow::ensure!(
!self.server.request_timeout.is_zero(),
"server.request_timeout must be positive"
Expand Down Expand Up @@ -1360,6 +1364,14 @@ mod tests {
assert_eq!(back.store.bucket, c.store.bucket);
}

#[test]
fn zero_per_repo_concurrency_is_rejected() {
let mut c = Config::default();
c.server.max_concurrent_per_repo = 0;
let err = c.validate().unwrap_err().to_string();
assert!(err.contains("server.max_concurrent_per_repo must be positive"));
}

#[test]
fn example_configurations_parse_and_validate() {
Config::parse(include_str!("../../../walgit.example.toml")).unwrap();
Expand Down