fix: reject failed LF1 polling before login finalization

[highesttt]

No description provided.

[indent]

Issues

1 potential issue found:

• The new LF1 failure paths, the loginPollingFailure/safeLoginPollingReason sanitization and the "LINE response without a valid code" branch have no tests, so redaction or downstream error classification could regress silently.
  _{Found by Indent Review Agent}

↑ Select any checkbox above to have Indent auto-fix the issue

1 issue already resolved

• Non-JSON or code-less error bodies (e.g. gateway 502 HTML, empty body) are reported as "LINE response code 0", which looks like LINE's success code and misleads log triage. Use a neutral message when no code is present. (fixed by commit 9809ab2)
  _{Found by Indent Review Agent}

CI Checks

All CI checks passed on 9809ab2.

Review agents

Select any unchecked box below to run or rerun that agent.

Found issues (1)

• Indent Review Agent · Code-0 nit is fixed and the format change breaks nothing; only the missing-tests nit remains.

Full results

Indent Review Agent

• Summary: Code-0 nit is fixed and the format change breaks nothing; only the missing-tests nit remains.
• Last ran on commit: 9809ab20
• Latest result

  {
    "summary": "Code-0 nit is fixed and the format change breaks nothing; only the missing-tests nit remains.",
    "findings": [
      {
        "fix": "Add table tests for `loginPollingFailure` covering: a 10051/TalkException body with a whitelisted reason, the same body with an unlisted reason (redacted), a non-JSON body, a JSON body without `code`, and a non-200 status. Then assert that `wrapLineLoginError` classifies the resulting error as expected.",
        "line": 260,
        "path": "pkg/line/errors.go",
        "issue": "This PR adds three new rejection paths in `waitForLoginLF1`: non-200, missing `code`, and nonzero `code`. It also adds the `loginPollingFailure`/`safeLoginPollingReason` sanitization, but there are no tests. The sanitization is the security-relevant part: it must not echo unlisted reasons, and its output has to stay parseable by `parseLoginErrorDetails` so that whitelisted reasons like \"blocked user\" still map to `ErrLoginTooManyAttempts` in `wrapLineLoginError`. A future change to either side could break that silently. The new no-code branch (\"LINE response without a valid code\") is also untested.",
        "title": "New LF1 failure handling has no tests",
        "severity": "nit"
      }
    ]
  }

[indent]

⚪️ Nit · New LF1 polling failure handling has no tests

Three new rejection paths (non-200, missing code, nonzero code) plus the reason whitelist have no tests. The whitelist is security-relevant, and its output must stay parseable by parseLoginErrorDetails so wrapLineLoginError keeps classifying errors correctly.

_{Found by Indent Review Agent}