Skip to content

fix: decode wrapped LINE token refresh responses - #260

Merged
highesttt merged 3 commits into
mainfrom
highest/plat-39178
Oct 7, 2026
Merged

highesttt merged 3 commits into
mainfrom
highest/plat-39178

Conversation

@highesttt

Copy link
Copy Markdown
Collaborator

No description provided.

@indent

indent Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Issues

All clear! No issues remaining. 🎉

2 issues already resolved
  • A refresh response with a valid top-level token and "data": null now fails. json.RawMessage holds the bytes null, so response.Data != nil is true and res is reset to an empty struct, which gives an empty AccessToken. (fixed by commit 2a02eaa)
    Found by Indent Review Agent
  • Classified refresh failures now carry a reason, but unclassified ones still return only refresh rejected: code N or refresh response missing access token. An unexpected LINE error code or unrecognized 200 body leaves nothing in the logs to diagnose it; the old error included the body. (fixed by commit 7cc6978)
    Found by Indent Review Agent

CI Checks

All CI checks passed on 7cc6978.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No new issues: earlier nit resolved; new diagnostic is panic-safe, leaks no secrets.
Full results

Indent Review Agent

  • Summary: No new issues: earlier nit resolved; new diagnostic is panic-safe, leaks no secrets.
  • Last ran on commit: 7cc69784
  • Latest result
    {
      "summary": "No new issues: earlier nit resolved; new diagnostic is panic-safe, leaks no secrets.",
      "findings": []
    }

@linear-code

linear-code Bot commented Oct 7, 2026

Copy link
Copy Markdown

PLAT-39178

Comment thread pkg/line/client.go Outdated
Comment thread pkg/line/errors.go
@highesttt
highesttt merged commit 90846b7 into main Oct 7, 2026
9 checks passed
@highesttt
highesttt deleted the highest/plat-39178 branch October 7, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant