Repository navigation
Conversation
Feature: newsletter-publishing/block-conversion/block-conversion-framework Implements: - US-006: A Group block becomes a beehiiv section holding its converted inner blocks Posts first synced with this change keep sections on later syncs. Posts synced before it keep omitting Group blocks.
…ehiiv payload beehiiv rejects a section inside a section, so the post failed to sync. A Group inside a Group is now omitted with its inner blocks, and the editor counts it in the omitted-block notice and marks it with the hidden icon.
…to beehiiv A linked post turns Send to newsletter off, which hid the notice and the hidden-block icon while its newsletter was still scheduled and syncing edits.
…the beehiiv sidebar is open The marker no longer wraps the block in an extra element. The hidden-eye icon is drawn on the block itself and stays visible without hovering.
…ollows the send warning text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
BlockConverterGroupTestcovers the section, nesting, empty and mixed Groups, default settings, and the first-sync and re-sync gateblock-conversion-framework.spec.jscovers the PRD acceptance criterialint:js,lint:cssandlint:phppassOpen questions left in the PRD: beehiiv's section nesting limit, and a Group inside Columns or another container.