Make teamChatManager public for optional integrations - #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modloader: Fabric
Minecraft version: 26.1.2
Summary
Changes
teamChatManagerfrom package-private topublic.This allows external mods to optionally query whether a player has Allied team chat enabled without modifying Allied's behavior.
A companion SDLink PR uses this to prevent Allied team chat messages from being relayed to Discord while keeping Allied as an optional dependency.
Changes
teamChatManagerpublic.Compatibility
This change is backwards compatible. It only changes the visibility of the class so other mods can access its existing public API.