Fix external_include_paths still using -iquote#730
Open
keith wants to merge 1 commit into
Open
Conversation
lilygorsheneva
previously approved these changes
Jun 8, 2026
Previously if you had an external repo but were setting `--features=external_include_paths` it would still contribute `-iquote` paths before the `-isystem` paths it was adding, so this wasn't working at all. This was only the case with clang. This also depends on the toolchain's ordering of these flags but in the default toolchains this feature comes after the default include paths feature. Fixes bazelbuild#729
keith
force-pushed
the
ks/fix-external_include_paths-still-using-iquote
branch
from
1df306e to
5eec01f
Compare
Member
Author
|
rebased to resolve the conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if you had an external repo but were setting
--features=external_include_pathsit would still contribute-iquotepaths before the
-isystempaths it was adding, so this wasn't workingat all. This was only the case with clang. This also depends on the
toolchain's ordering of these flags but in the default toolchains this
feature comes after the default include paths feature.
Fixes #729