fix framework imports with private swiftinterface#2921
Open
fix framework imports with private swiftinterface#2921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported frameworks/XCFrameworks can ship both a primary
.swiftinterfacefile and a companion.private.swiftinterfacefile for the selected target triplet. We were only propagating a single Swift interface input, which could cause Swiftcompilation to miss the private interface when importing the framework.
To fix it:
.privateinterface filesWe didn't see this fail since when building with
rules_xcodeprojsandbox is disabled thus those files were getting discovered. Enablingsandboxedorworkerstrategy forSwiftCompileandSwiftDeriveFilesmnemonic surfaces the issue.