Provide default Info.plist for *_application rules#2919
Provide default Info.plist for *_application rules#2919ssarad wants to merge 5 commits intobazelbuild:mainfrom
Conversation
keith
left a comment
There was a problem hiding this comment.
is the way that xcode treats this plist just that it's a default and if you have custom stuff? or does it always merge it in to whatever you provide too? if it's the latter i wonder if instead of just treating this as a default if we should just do something more like default_plist | user_plist always.
also can this apply to more targets than just ios_application? i assume some others could benefit from this too?
this is very nice to do, i always find this annoying in simple cases
| "ipad", | ||
| ], | ||
| infoplists = [":Info.plist"], | ||
| infoplists = [":Info.plist"], # Optional; a default Info.plist will be used if not provided |
There was a problem hiding this comment.
| infoplists = [":Info.plist"], # Optional; a default Info.plist will be used if not provided |
i think we should toss this from the example. IMO the value of this example is just providing the most minimal info
There was a problem hiding this comment.
Yeah, makes sense. Also for
is the way that xcode treats this plist just that it's a default and if you have custom stuff? or does it always merge it in to whatever you provide too? if it's the latter i wonder if instead of just treating this as a default if we should just do something more like default_plist | user_plist always.
Its actually due to some custom stuff but also we are moving towards a monorepo setup so before all apps join, they'd want to evaluate and play around with simple Bazel setup and often times I'm running myself into creating these info.plist which I realized could be much simpler if we just made a default one like Xcode does
There was a problem hiding this comment.
also can this apply to more targets than just ios_application? i assume some others could benefit from this too?
Yeah this was my thinking too - should we expand to all *_applications? I think yes, and I'll do that and make the push, if you feel we want to scope it to just ios_application or macos_application, let me know
Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Fixes #1858
The issue is quite old but we're currently at a larger monorepo with several apps so I figured this would be nice to get in. In this PR, I focused mostly on
ios_applicationbut happy to hear some thoughts if we want to expand this towards*_application