Skip to content

Commit 19c7caf

Browse files
authored
Pass --zip_undeclared_test_outputs to ios_coverage_test.sh (#2531)
The default flipped to false in this commit: bazelbuild/bazel@489d08b
1 parent 1053ce7 commit 19c7caf

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

test/ios_coverage_test.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -246,26 +246,26 @@ EOF
246246

247247
function test_standalone_unit_test_coverage() {
248248
create_common_files
249-
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap //app:standalone_test || fail "Should build"
249+
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap --zip_undeclared_test_outputs //app:standalone_test || fail "Should build"
250250
assert_contains "SharedLogic.m:-\[SharedLogic doSomething\]" "test-testlogs/app/standalone_test/coverage.dat"
251251
}
252252

253253
function test_standalone_unit_test_coverage_new_runner() {
254254
create_common_files
255-
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap //app:standalone_test_new_runner || fail "Should build"
255+
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap --zip_undeclared_test_outputs //app:standalone_test_new_runner || fail "Should build"
256256
assert_contains "SharedLogic.m:-\[SharedLogic doSomething\]" "test-testlogs/app/standalone_test/coverage.dat"
257257
}
258258

259259
function test_standalone_unit_test_coverage_json() {
260260
create_common_files
261-
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap --test_env=COVERAGE_PRODUCE_JSON=1 //app:standalone_test || fail "Should build"
261+
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap --zip_undeclared_test_outputs --test_env=COVERAGE_PRODUCE_JSON=1 //app:standalone_test || fail "Should build"
262262
unzip_single_file "test-testlogs/app/standalone_test/test.outputs/outputs.zip" coverage.json \
263263
grep -q '"name":"SharedLogic.m:-\[SharedLogic doSomething\]"'
264264
}
265265

266266
function test_standalone_unit_test_coverage_coverage_manifest() {
267267
create_common_files
268-
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap //app:coverage_manifest_test || fail "Should build"
268+
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap --zip_undeclared_test_outputs //app:coverage_manifest_test || fail "Should build"
269269
assert_contains "SharedLogic.m:-\[SharedLogic doSomething\]" "test-testlogs/app/coverage_manifest_test/coverage.dat"
270270
assert_contains "SF:app/SharedLogic.m" "test-testlogs/app/coverage_manifest_test/coverage.dat"
271271
cat "test-testlogs/app/coverage_manifest_test/coverage.dat"
@@ -274,7 +274,7 @@ function test_standalone_unit_test_coverage_coverage_manifest() {
274274

275275
function test_standalone_unit_test_coverage_coverage_manifest_new_runner() {
276276
create_common_files
277-
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap //app:coverage_manifest_test_new_runner || fail "Should build"
277+
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap --zip_undeclared_test_outputs //app:coverage_manifest_test_new_runner || fail "Should build"
278278
assert_contains "SharedLogic.m:-\[SharedLogic doSomething\]" "test-testlogs/app/coverage_manifest_test_new_runner/coverage.dat"
279279
assert_contains "SF:app/SharedLogic.m" "test-testlogs/app/coverage_manifest_test_new_runner/coverage.dat"
280280
cat test-testlogs/app/coverage_manifest_test_new_runner/coverage.dat
@@ -283,7 +283,7 @@ function test_standalone_unit_test_coverage_coverage_manifest_new_runner() {
283283

284284
function test_hosted_unit_test_coverage() {
285285
create_common_files
286-
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap //app:hosted_test || fail "Should build"
286+
do_coverage ios --test_output=errors --ios_minimum_os=9.0 --experimental_use_llvm_covmap --zip_undeclared_test_outputs //app:hosted_test || fail "Should build"
287287

288288
# Validate normal coverage is included
289289
assert_contains "SharedLogic.m:-\[SharedLogic doSomething\]" "test-testlogs/app/hosted_test/coverage.dat"
@@ -306,7 +306,7 @@ function test_hosted_unit_test_coverage() {
306306

307307
function test_ui_test_coverage_new_runner() {
308308
create_common_files
309-
do_coverage ios --test_output=errors --ios_minimum_os=15.0 --experimental_use_llvm_covmap //app:test_coverage_ui_test_new_runner || fail "Should build"
309+
do_coverage ios --test_output=errors --ios_minimum_os=15.0 --experimental_use_llvm_covmap --zip_undeclared_test_outputs //app:test_coverage_ui_test_new_runner || fail "Should build"
310310
assert_contains "DA:5,1" "test-testlogs/app/test_coverage_ui_test_new_runner/coverage.dat"
311311
}
312312

0 commit comments

Comments
 (0)