Make cc_info_dylibs_partial handle only .dylib files. (#2516) (#2517)

hiroyuki-komatsu · web-flow · commit 1053ce731d77 · 2024-09-10T11:47:38.000-05:00
This change will fix #2516.
diff --git a/apple/internal/partials/cc_info_dylibs.bzl b/apple/internal/partials/cc_info_dylibs.bzl
@@ -32,7 +32,7 @@ def _cc_info_dylibs_partial_impl(
         cc_info = target[CcInfo]
         for linker_input in cc_info.linking_context.linker_inputs.to_list():
             for library in linker_input.libraries:
-                if library.dynamic_library:
+                if library.dynamic_library and library.dynamic_library.extension == "dylib":
                     bundle_files.append(
                         (processor.location.framework, None, depset([library.dynamic_library])),
                     )

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ def _cc_info_dylibs_partial_impl(`
`32`	`32`	`cc_info = target[CcInfo]`
`33`	`33`	`for linker_input in cc_info.linking_context.linker_inputs.to_list():`
`34`	`34`	`for library in linker_input.libraries:`
`35`		`- if library.dynamic_library:`
	`35`	`+ if library.dynamic_library and library.dynamic_library.extension == "dylib":`
`36`	`36`	`bundle_files.append(`
`37`	`37`	`(processor.location.framework, None, depset([library.dynamic_library])),`
`38`	`38`	`)`