Silence duplicate option warnings from lower priority expansion#30118
Open
keith wants to merge 1 commit into
Open
Silence duplicate option warnings from lower priority expansion#30118keith wants to merge 1 commit into
keith wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
awaiting-review
Previously this config: ``` common:default --bes_results_url=remote.buildbuddy.io common --config=default common:override --bes_results_url=buildbuddy.buildbuddy.io ``` With `bazel build --config=override ...` would result in: ``` WARNING: option '--bes_results_url' was expanded from both option '--config=default' (source /.../.bazelrc) and option '--config=override' (source command line options) ``` Now we correctly treat the default config as coming from the lower priority RC file
keith
force-pushed
the
ks/silence-duplicate-option-warnings-from-lower-priority-expansion
branch
from
3dfb62c to
ba886b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this config:
With
bazel build --config=override ...would result in:Now we correctly treat the default config as coming from the lower
priority RC file